Actions
Bug #24791
openInconsistent help and actual command
Status:
New
Priority:
Normal
Assignee:
-
Target version:
-
% Done:
0%
Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
The help for the activation command says:
[root@ceph-osd0 /]# ceph-volume lvm activate
Activate OSDs by discovering them with LVM and mounting them in their
appropriate destination:
ceph-volume lvm activate {ID} {FSID}
The lvs associated with the OSD need to have been prepared previously,
so that all needed tags and metadata exist.
When migrating OSDs, or a multiple-osd activation is needed, the
``--all`` flag can be used instead of the individual ID and FSID:
ceph-volume lvm activate --all
So if I want to activate a single OSD at a time it seems that I need to do:
ceph-volume lvm activate {ID} {FSID}
However, the following works:
[root@ceph-osd0 /]# ceph-volume lvm activate --no-systemd /dev/sda Running command: /bin/ceph-bluestore-tool --cluster=ceph prime-osd-dir --dev /dev/ceph-c8643732-44a6-4db4-9cde-b9b9a4487e1b/osd-block-1ac9a173-4a83-4dc4-b1a1-4343f72236c3 --path /var/lib/ceph/osd/ceph-0 Running command: /bin/ln -snf /dev/ceph-c8643732-44a6-4db4-9cde-b9b9a4487e1b/osd-block-1ac9a173-4a83-4dc4-b1a1-4343f72236c3 /var/lib/ceph/osd/ceph-0/block Running command: /bin/chown -R ceph:ceph /dev/mapper/ceph--c8643732--44a6--4db4--9cde--b9b9a4487e1b-osd--block--1ac9a173--4a83--4dc4--b1a1--4343f72236c3 Running command: /bin/chown -R ceph:ceph /var/lib/ceph/osd/ceph-0 --> ceph-volume lvm activate successful for osd ID: 0
Updated by Alfredo Deza almost 6 years ago
- Status changed from New to 12
Wow, this is a great catch. Going through the code, this is not the intention at all :(
What is happening here is that the code is not getting an explicit FSID or ID, but it is still finding LVs that need activation. If I am reading this correctly, I think that
you can pass in "foo" and it would still work.
This is basically the behavior of `activate --all`. We will need to make changes to prevent this situation
Updated by Sébastien Han almost 6 years ago
Ok thanks, also I think we should clarify that we are looking for OSD FSID and not the cluster FSID.
I suspect some users might get confused.
Using the ID and FSID as the helper says works as expected.
Actions