Project

General

Profile

Actions

Bug #24564

closed

perfcounter unit enum redeclaration

Added by Qiaowei Ren almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Build
Target version:
-
% Done:

100%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

the error about enum redeclaration during compile time:

error: redeclaration of enumerator 'NONE'
error: previous definition of 'NONE' ...

The error is from the enum declaration in src/common/perf_counters.h:

enum unit_t : uint8_t {
BYTES,
NONE
};

bug fix commit: https://github.com/ceph/ceph/pull/22615

Actions #1

Updated by John Spray almost 6 years ago

  • Project changed from Ceph to mgr
  • Subject changed from enum redeclaration to perfcounter unit enum redeclaration
  • Category changed from build to Build
  • Status changed from New to Fix Under Review

(no natural subproject for this so pulling it into mgr to get it off the triage queue)

The fix looks reasonable. What was the particular environment/compiler where this was failing?

Actions #2

Updated by Qiaowei Ren almost 6 years ago

My base system is ubuntu 18.04, and I checked that the c++ version is 7.3.0 and it should be based on c++17.

Actions #3

Updated by Kefu Chai almost 6 years ago

  • Assignee set to Qiaowei Ren
Actions #4

Updated by Ricardo Marques almost 6 years ago

  • Status changed from Fix Under Review to 17
Actions #5

Updated by Ricardo Marques almost 6 years ago

  • Status changed from 17 to Fix Under Review
Actions #6

Updated by John Spray over 5 years ago

  • Status changed from Fix Under Review to Closed
Actions

Also available in: Atom PDF