Project

General

Profile

Backport #24546

luminous: rgw: change order of authentication back to local, remote

Added by Nathan Cutler over 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Target version:
Release:
luminous
Crash signature:


Related issues

Copied from rgw - Bug #23089: rgw: change order of authentication back to local, remote Resolved 02/22/2018

History

#1 Updated by Nathan Cutler over 1 year ago

  • Copied from Bug #23089: rgw: change order of authentication back to local, remote added

#2 Updated by Nathan Cutler over 1 year ago

  • Description updated (diff)
  • Status changed from New to In Progress
  • Assignee set to Nathan Cutler

#3 Updated by Nathan Cutler over 1 year ago

  • Status changed from In Progress to Need More Info
  • Assignee deleted (Nathan Cutler)

luminous backport is non-trivial due to C++14 and C++17isms in the master commit

In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_keystone.cc:22:0:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h:140:47: error: ‘parse_auth_order’ function uses ‘auto’ type specifier without trailing return type
   auto parse_auth_order(CephContext* const cct)
                                               ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h:140:47: note: deduced return type only available with -std=c++14 or -std=gnu++14
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h: In member function ‘void rgw::auth::s3::AWSAuthStrategy<AbstractorT, AllowAnonAccessT>::add_engines(const std::vector<std::__cxx11::basic_string<char> >&, rgw::auth::s3::AWSAuthStrategy<AbstractorT, AllowAnonAccessT>::engine_map_t)’:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h:133:44: error: expected ‘)’ before ‘;’ token
       if (const auto kv = eng_map.find(eng);
                                            ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h:134:11: error: ‘kv’ was not declared in this scope
           kv != eng_map.end()) {
           ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h: In member function ‘auto rgw::auth::s3::AWSAuthStrategy<AbstractorT, AllowAnonAccessT>::parse_auth_order(CephContext*)’:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h:144:21: error: ‘string_view’ is not a member of ‘std’
     const std::set <std::string_view> allowed_auth = { "external", "local" };
                     ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h:144:21: note: suggested alternative:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/build/boost/include/boost/utility/string_view.hpp:22:0,
                 from /home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_b64.h:8,
                 from /home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_keystone.cc:10:
/home/jenkins-build/build/workspace/ceph-pull-requests/build/boost/include/boost/utility/string_view_fwd.hpp:26:62: note:   ‘boost::string_view’
     typedef basic_string_view<char,     std::char_traits<char> >        string_view;
                                                              ^
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_keystone.cc:22:0:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h:144:21: error: ‘string_view’ is not a member of ‘std’
     const std::set <std::string_view> allowed_auth = { "external", "local" };
                     ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h:144:21: note: suggested alternative:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/build/boost/include/boost/utility/string_view.hpp:22:0,
                 from /home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_b64.h:8,
                 from /home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_keystone.cc:10:
/home/jenkins-build/build/workspace/ceph-pull-requests/build/boost/include/boost/utility/string_view_fwd.hpp:26:62: note:   ‘boost::string_view’
     typedef basic_string_view<char,     std::char_traits<char> >        string_view;
                                                              ^
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_keystone.cc:22:0:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h:144:37: error: template argument 1 is invalid
     const std::set <std::string_view> allowed_auth = { "external", "local" };
                                     ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h:144:37: error: template argument 2 is invalid
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h:144:37: error: template argument 3 is invalid
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h:144:76: error: scalar object ‘allowed_auth’ requires one element in initializer
     const std::set <std::string_view> allowed_auth = { "external", "local" };
                                                                            ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h:151:27: error: ‘std::string_view’ has not been declared
       [allowed_auth](std::string_view s)
                           ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h: In lambda function:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h:152:16: error: ‘allowed_auth’ is not captured
       { return allowed_auth.find(s) == allowed_auth.end();})){
                ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h:151:20: note: the lambda has no capture-default
       [allowed_auth](std::string_view s)
                    ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h:144:39: note: ‘<typeprefixerror>allowed_auth’ declared here
     const std::set <std::string_view> allowed_auth = { "external", "local" };
                                       ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h:152:40: error: ‘allowed_auth’ is not captured
       { return allowed_auth.find(s) == allowed_auth.end();})){
                                        ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h:151:20: note: the lambda has no capture-default
       [allowed_auth](std::string_view s)
                    ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_auth_s3.h:144:39: note: ‘<typeprefixerror>allowed_auth’ declared here
     const std::set <std::string_view> allowed_auth = { "external", "local" };
                                       ^
src/rgw/CMakeFiles/rgw_a.dir/build.make:162: recipe for target 'src/rgw/CMakeFiles/rgw_a.dir/rgw_auth_keystone.cc.o' failed
make[3]: *** [src/rgw/CMakeFiles/rgw_a.dir/rgw_auth_keystone.cc.o] Error 1
CMakeFiles/Makefile2:22696: recipe for target 'src/rgw/CMakeFiles/rgw_a.dir/all' failed

#4 Updated by Abhishek Lekshmanan over 1 year ago

  • Description updated (diff)
  • Status changed from Need More Info to In Progress

#5 Updated by Abhishek Lekshmanan over 1 year ago

  • Description updated (diff)

#6 Updated by Yuri Weinstein over 1 year ago

Nathan Cutler wrote:

https://github.com/ceph/ceph/pull/23501/

merged

#7 Updated by Abhishek Lekshmanan over 1 year ago

  • Status changed from In Progress to Resolved
  • Target version set to v12.2.8

#8 Updated by Nathan Cutler about 1 year ago

  • Assignee set to Abhishek Lekshmanan

Also available in: Atom PDF