Backport #24260: luminous: bluestore: flush_commit is racy - bluestore - Ceph

Actions

Copy link

Backport #24260

closed

luminous: bluestore: flush_commit is racy

Added by Nathan Cutler almost 6 years ago. Updated over 5 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Igor Fedotov

Target version:

Release:

luminous

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

https://github.com/ceph/ceph/pull/22904

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Nathan Cutler almost 6 years ago

Copied from Bug #21480: bluestore: flush_commit is racy added

Actions

Copy link

Updated by Prashant D almost 6 years ago

Status changed from New to Need More Info

Backporting changes related to tracker21480 needs additional PR to be backported. The ch and osr are included (and defined) in PR#20173 :
abd58ad0b9a src/os/bluestore/BlueStore.h (Sage Weil 2018-01-15 15:23:46 0600 1563) CollectionRef ch;
abd58ad0b9a src/os/bluestore/BlueStore.h (Sage Weil 2018-01-15 15:23:46 -0600 1564) OpSequencerRef osr; // this should be ch>osr

Actions

Copy link

Updated by Nathan Cutler almost 6 years ago

Assignee set to Igor Fedotov

According to @Prashant this depends on https://github.com/ceph/ceph/pull/20173 which seems too big to backport to luminous at this stage.

@Igor Gajowiak what do you think?

Actions

Copy link

Updated by Nathan Cutler almost 6 years ago

So it looks like ch was introduced by https://github.com/ceph/ceph/commit/abd58ad0b9a1a1564f96e2e2b8e1d2d7c832f7cf (which is non-trivial to backport to luminous) but I believe a bluestore developer could cherry-pick the commits from https://github.com/ceph/ceph/pull/22083 and manually adapt them for luminous.

Actions

Copy link