Project

General

Profile

Actions

Bug #24140

closed

[rbd-mirror] interrupted image sync can result in orphaned snapshots

Added by Jason Dillaman almost 6 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jason Dillaman
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
luminous,mimic
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

This can lead to a race if the snapshot is the parent for a clone and the clone starts to replicate (thus attaching itself to the parent). This child will prevent the snapshot copy logic from unprotecting/deleting the (unknown) snapshot since it has a new child. Since the clone logic looks up the parent snapshot by name in rbd-mirror, perhaps the snapshot create logic can utilize a dummy snapshot name upon creation, update the snap_seq mapping on disk, and then rename the snapshot to the correct name.


Related issues 2 (0 open2 closed)

Copied to rbd - Backport #36154: luminous: [rbd-mirror] interrupted image sync can result in orphaned snapshotsRejectedJason DillamanActions
Copied to rbd - Backport #36155: mimic: [rbd-mirror] interrupted image sync can result in orphaned snapshotsRejectedJason DillamanActions
Actions #1

Updated by Jason Dillaman almost 6 years ago

  • Backport changed from luminous to luminous,mimic
Actions #3

Updated by Jason Dillaman over 5 years ago

  • Status changed from New to In Progress
  • Assignee set to Jason Dillaman
Actions #4

Updated by Jason Dillaman over 5 years ago

The alternative (and easier) approach is to prevent rbd-mirror from creating a clone if the parent image is still syncing.

Actions #5

Updated by Jason Dillaman over 5 years ago

  • Status changed from In Progress to Fix Under Review
Actions #6

Updated by Mykola Golub over 5 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #7

Updated by Nathan Cutler over 5 years ago

  • Copied to Backport #36154: luminous: [rbd-mirror] interrupted image sync can result in orphaned snapshots added
Actions #8

Updated by Nathan Cutler over 5 years ago

  • Copied to Backport #36155: mimic: [rbd-mirror] interrupted image sync can result in orphaned snapshots added
Actions #9

Updated by Jason Dillaman about 4 years ago

  • Status changed from Pending Backport to Resolved
Actions #10

Updated by Nathan Cutler almost 4 years ago

  • Pull request ID set to 24063
Actions #11

Updated by Nathan Cutler almost 4 years ago

  • Status changed from Resolved to Pending Backport

@Jason Borden - the mimic backport is still open

Actions #12

Updated by Jason Dillaman almost 4 years ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF