Project

General

Profile

Bug #24140

[rbd-mirror] interrupted image sync can result in orphaned snapshots

Added by Jason Dillaman over 1 year ago. Updated 11 months ago.

Status:
Pending Backport
Priority:
Normal
Target version:
-
Start date:
05/15/2018
Due date:
% Done:

0%

Source:
Tags:
Backport:
luminous,mimic
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

This can lead to a race if the snapshot is the parent for a clone and the clone starts to replicate (thus attaching itself to the parent). This child will prevent the snapshot copy logic from unprotecting/deleting the (unknown) snapshot since it has a new child. Since the clone logic looks up the parent snapshot by name in rbd-mirror, perhaps the snapshot create logic can utilize a dummy snapshot name upon creation, update the snap_seq mapping on disk, and then rename the snapshot to the correct name.


Related issues

Copied to rbd - Backport #36154: luminous: [rbd-mirror] interrupted image sync can result in orphaned snapshots In Progress
Copied to rbd - Backport #36155: mimic: [rbd-mirror] interrupted image sync can result in orphaned snapshots In Progress

History

#1 Updated by Jason Dillaman over 1 year ago

  • Backport changed from luminous to luminous,mimic

#3 Updated by Jason Dillaman 12 months ago

  • Status changed from New to In Progress
  • Assignee set to Jason Dillaman

#4 Updated by Jason Dillaman 12 months ago

The alternative (and easier) approach is to prevent rbd-mirror from creating a clone if the parent image is still syncing.

#5 Updated by Jason Dillaman 12 months ago

  • Status changed from In Progress to Need Review

#6 Updated by Mykola Golub 11 months ago

  • Status changed from Need Review to Pending Backport

#7 Updated by Nathan Cutler 11 months ago

  • Copied to Backport #36154: luminous: [rbd-mirror] interrupted image sync can result in orphaned snapshots added

#8 Updated by Nathan Cutler 11 months ago

  • Copied to Backport #36155: mimic: [rbd-mirror] interrupted image sync can result in orphaned snapshots added

Also available in: Atom PDF