Project

General

Profile

Bug #24081

Dashboard: Float numbers incorrectly formatted

Added by Ricardo Marques over 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Category:
dashboard/general
Target version:
Start date:
05/10/2018
Due date:
% Done:

0%

Source:
Tags:
dashboard
Backport:
mimic
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:

Description

dimless pipe is not correctly formatting float values.

See attached image where value 0.6 is formatted to 600undefined.

This bug was introduced by PR https://github.com/ceph/ceph/pull/21677

Screenshot_20180510_152131.png View (49 KB) Ricardo Marques, 05/10/2018 03:00 PM


Related issues

Copied to mgr - Backport #24707: mimic: Dashboard: Float numbers incorrectly formatted Resolved

Associated revisions

Revision b8ecac36 (diff)
Added by Stephan Müller over 1 year ago

mgr/dashboard: Format small numbers correctly

The issue was triggered by numbers that a lower than 1.
Doing a logarithm with a number lower than 1 leads to
negative value that is not handled anywhere in The formatter service as
a result the final value will be quirky.
The negative number will also be used as index in the units array, where
it will return "undefined".

Fixes #24081

Signed-off-by: Stephan Müller <>

Revision 3628df7d (diff)
Added by Stephan Müller about 1 year ago

mgr/dashboard: Format small numbers correctly

The issue was triggered by numbers that a lower than 1.
Doing a logarithm with a number lower than 1 leads to
negative value that is not handled anywhere in The formatter service as
a result the final value will be quirky.
The negative number will also be used as index in the units array, where
it will return "undefined".

Fixes #24081

Signed-off-by: Stephan Müller <>
(cherry picked from commit b8ecac3603c01764d83e2b8862f3b6f847321e85)

History

#1 Updated by Lenz Grimmer over 1 year ago

  • Subject changed from Float numbers incorrectly formatted to Dashboard: Float numbers incorrectly formatted
  • Assignee changed from Lenz Grimmer to Stephan Müller
  • Target version set to v13.2.0

Stephan, can you please look into this and prepare a fix for the Mimic release? Thanks!

#2 Updated by Stephan Müller over 1 year ago

  • Status changed from New to Need Review

The PR that fixes the bug can be found here

#3 Updated by Lenz Grimmer about 1 year ago

  • Status changed from Need Review to Pending Backport
  • Backport set to mimic

#4 Updated by Patrick Donnelly about 1 year ago

  • Copied to Backport #24707: mimic: Dashboard: Float numbers incorrectly formatted added

#5 Updated by Nathan Cutler about 1 year ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF