Bug #23805: ceph-helpers.sh tries to use dirname without mandatory parameter - Ceph - Ceph

Actions

Copy link

Bug #23805

closed

ceph-helpers.sh tries to use dirname without mandatory parameter

Added by Nathan Cutler about 6 years ago. Updated over 5 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Nathan Cutler

Category:

Target version:

% Done:

Source:

Tags:

Backport:

luminous

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

/home/smithfarm/ceph/qa/standalone/ceph-helpers.sh:161: teardown:  dirname
dirname: missing operand
Try 'dirname --help' for more information.

The problem is in this code:

    local pattern="$(sysctl -n $KERNCORE)" 
    # See if we have apport core handling
    if [ "${pattern:0:1}" = "|" ]; then
      # TODO: Where can we get the dumps?
      # Not sure where the dumps really are so this will look in the CWD
      pattern="" 
    fi
    # Local we start with core and teuthology ends with core
    if ls $(dirname $pattern) | grep -q '^core\|core$' ; then

pattern gets set to "", which triggers the error. Interestingly, if we do dirname "" explicitly, it works.

Related issues 1 (0 open — 1 closed)