Project

General

Profile

Actions

Bug #23491

closed

fs: quota backward compatibility

Added by Patrick Donnelly about 6 years ago. Updated about 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Client, MDS, kceph
Labels (FS):
snapshots
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Since

commit f93f56eda9d989969af4bc173cd512216e159afc HEAD (upstream/pull/18424/head)
Author: Yan, Zheng <zyan@redhat.com>
Date:   Fri Oct 20 17:55:26 2017 +0800

    mds: create snaprealm for quota enabled inode

    this simplifies client code for find quota enabled inode

    Signed-off-by: "Yan, Zheng" <zyan@redhat.com>

We now use SnapRealms to manage quotas. Zheng, after thinking about this more I'm not sure if a compatibility flag will make sense for older clients. Should we prevent older clients from writing to directories with quotas if they do not know how to enforce the quota?

We also need to consider a feature flag (require_mimic_mds) for MDS upgrades. What do you think?

Actions #1

Updated by Greg Farnum about 6 years ago

There definitely needs to be something to keep this feature turned off until all the MDSes have upgraded. That may just be a new MDSMap ComaptSet feature?

Actions #2

Updated by Zheng Yan about 6 years ago

old user space client talking to new mds is OK. new client talking to old mds may have problem.

Actions #3

Updated by Zheng Yan about 6 years ago

will there be feature bit for mimic. If there will be, it's easy to add a mds version check to client

Actions #4

Updated by Zheng Yan about 6 years ago

  • Subject changed from fs: add flag to mdsmap to indicate to quota handling (using quota realms) to fs: quota backward compatibility
  • Status changed from New to Fix Under Review
Actions #5

Updated by Patrick Donnelly about 6 years ago

  • Status changed from Fix Under Review to Resolved
  • Tags deleted (snapshots)
  • Labels (FS) snapshots added
Actions

Also available in: Atom PDF