Project

General

Profile

Bug #2345

mon: users can create both pool snapshots and self-managed snapshots on a single pool

Added by Greg Farnum over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Monitor
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

When the OSD gets the map it breaks, but the Monitor will happily set both. There should be guard against that.
(See http://marc.info/?l=ceph-devel&m=133534478717808&w=2)

Associated revisions

Revision 18790b1f (diff)
Added by Greg Farnum over 8 years ago

osd: add is_unmanaged_snaps_mode() to pg_pool_t; use more consistently

Create an is_unmanaged_snaps_mode() function to parallel
is_pool_snaps_mode(), and replace all the checks directly referencing
removed_snaps or snaps with calls to these functions.
Fixes #2345.

Signed-off-by: Greg Farnum <>

History

#1 Updated by Greg Farnum over 8 years ago

  • Status changed from New to In Progress

Ah, there are Monitor checks for this but they aren't quite right: they look at the contents of snaps and removed_snaps, but don't consider the possibility that these things previously existed but have been erased.
I'm simplifying this by making use of the is_pool_snaps_mode() check (and adding a similar is_unmanaged_snaps_mode()).

#2 Updated by Greg Farnum over 8 years ago

  • Status changed from In Progress to Fix Under Review

Pushed a fix (and tested it using rados snap create and rbd snap create) to wip-2345-snaps.

#3 Updated by Sage Weil over 8 years ago

  • Status changed from Fix Under Review to Resolved

Also available in: Atom PDF