Project

General

Profile

Cleanup #2344

convert Monitor maps to use ENCODE_START

Added by Greg Farnum about 8 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Monitor
Target version:
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Looks like the Monitor stuff doesn't use the ENCODE_START idiom at all, and it should.

History

#1 Updated by Sage Weil about 8 years ago

  • Status changed from New to Fix Under Review

wip-mon-encoding

#2 Updated by Greg Farnum about 8 years ago

The PGMap changes there are fine, but there are several others:
AuthMonitor::Incremental
MonCaps
MonMap
OSDMap

Are the ones I can see in a quick check.

#3 Updated by Sage Weil about 8 years ago

  • Status changed from Fix Under Review to In Progress
  • translation missing: en.field_position set to 1228

#4 Updated by Sage Weil about 8 years ago

  • Target version changed from v0.47 to v0.48

#5 Updated by Greg Farnum about 8 years ago

MonCaps look good; I'm a bit concerned about the "all features" default used for the MonMap (left a note on GitHub) but the rest is good.

Leaves AuthMonitor::Incremental and OSDMap. :)

#6 Updated by Sage Weil about 8 years ago

  • Status changed from In Progress to Fix Under Review

#7 Updated by Greg Farnum about 8 years ago

Looks good. Reviewed-by: Greg Farnum. :)

#8 Updated by Sage Weil about 8 years ago

  • Status changed from Fix Under Review to Resolved

Also available in: Atom PDF