Actions
Cleanup #2344
closedconvert Monitor maps to use ENCODE_START
% Done:
0%
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:
Description
Looks like the Monitor stuff doesn't use the ENCODE_START idiom at all, and it should.
Updated by Sage Weil almost 12 years ago
- Status changed from New to Fix Under Review
wip-mon-encoding
Updated by Greg Farnum almost 12 years ago
The PGMap changes there are fine, but there are several others:
AuthMonitor::Incremental
MonCaps
MonMap
OSDMap
Are the ones I can see in a quick check.
Updated by Sage Weil almost 12 years ago
- Status changed from Fix Under Review to In Progress
- Translation missing: en.field_position set to 1228
Updated by Sage Weil almost 12 years ago
- Target version changed from v0.47 to v0.48
Updated by Greg Farnum almost 12 years ago
MonCaps look good; I'm a bit concerned about the "all features" default used for the MonMap (left a note on GitHub) but the rest is good.
Leaves AuthMonitor::Incremental and OSDMap. :)
Updated by Sage Weil almost 12 years ago
- Status changed from In Progress to Fix Under Review
Updated by Greg Farnum almost 12 years ago
Looks good. Reviewed-by: Greg Farnum. :)
Updated by Sage Weil almost 12 years ago
- Status changed from Fix Under Review to Resolved
Actions