Project

General

Profile

Feature #23397

Central "mgr self-test <module>" command

Added by John Spray about 6 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
ceph-mgr
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Currently, many of the manager modules implement a "self-test" command (validate that they can fetch and parse their data, etc). The current downsides are:

1) it's repetitive boilerplate in the command definitions
2) we are polluting the output of "ceph --help" on real systems with these commands which are only used in test environments.

So, let's let the modules just implement a `self_test` python function, and handle the command part centrally from the existing selftest module. That way, the modules don't have to do the command handling, and the command will only be visible when the selftest module is loaded.

A draft implementation of the function calling between modules is in https://github.com/jcsp/ceph/commit/8fd322796a128162318fe249eca558274bcc4cfd

History

#1 Updated by John Spray over 5 years ago

  • Status changed from New to Resolved
  • Assignee changed from Rubab Syed to John Spray

This was done at the same time MgrModule.remote() was added

Also available in: Atom PDF