Bug #23247: doc: distinguish versions in ceph-fuse - CephFS - Ceph

Actions

Copy link

Bug #23247

closed

doc: distinguish versions in ceph-fuse

Added by Jos Collin about 6 years ago. Updated almost 6 years ago.

Status:

Won't Fix

Priority:

Normal

Assignee:

Jos Collin

Category:

Administration/Usability

Target version:

Ceph - v13.0.0

% Done:

100%

Source:

Community (dev)

Tags:

Backport:

luminous

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(FS):

Labels (FS):

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

ceph-fuse: general options shows:

-V   --version         print version

Which is for displaying Fuse Library version.

generic_usage() displays:

  --version         show version and quit

Which is for displaying ceph version 13.0.1.

So why the help shows --version for 2 different things ?

Subtasks 1 (0 open — 1 closed)

Actions

Copy link

Updated by Patrick Donnelly about 6 years ago

Subject changed from distinguish versions in ceph-fuse to doc: distinguish versions in ceph-fuse
Assignee set to Jos Collin
Target version set to v13.0.0
Backport set to luminous

Jos, finding out the version of FUSE and of ceph-fuse is valuable. I think the --version switch should be used for both. Please make sure that's the current behavior and adjust the output as necessary.

Actions

Copy link

Updated by Jos Collin about 6 years ago

Patrick Donnelly wrote:

Jos, finding out the version of FUSE and of ceph-fuse is valuable. I think the --version switch should be used for both. Please make sure that's the current behavior and adjust the output as necessary.

Patrick,

The current behavior of --version is that it prints only:

ceph version 13.0.1-2834-g9ffbac6fc5 (9ffbac6fc5c7ac23d4a6096c7a9636b9df8efc00) mimic (dev)

(not the FUSE version). This is correct as per ceph-fuse.

Now the problem is that we are calling https://github.com/ceph/ceph/blob/master/src/ceph_fuse.cc#L54 for getting FUSE options, in which --version is used for showing the FUSE version. So we have an ambiguity, when these two usages are combined for 'ceph-fuse -h'. But they are correct if they are displayed individually.

The ambiguity is that in 'ceph-fuse -h' usage, --version option is for displaying FUSE version or ceph-fuse version.

Actions

Copy link

Updated by Patrick Donnelly about 6 years ago

Jos Collin wrote:

Now the problem is that we are calling https://github.com/ceph/ceph/blob/master/src/ceph_fuse.cc#L54 for getting FUSE options, in which --version is used for showing the FUSE version. So we have an ambiguity, when these two usages are combined for 'ceph-fuse -h'. But they are correct if they are displayed individually.

The ambiguity is that in 'ceph-fuse -h' usage, --version option is for displaying FUSE version or ceph-fuse version.

I understand. Is it possible to allow FUSE to process --version as well so that it can print its version. Then ceph-fuse can print Ceph's version and exit.

Actions

Copy link

Updated by Jos Collin about 6 years ago

Patrick Donnelly wrote:

I understand. Is it possible to allow FUSE to process --version as well so that it can print its version. Then ceph-fuse can print Ceph's version and exit.

As per your suggestion, I tried some samples for using --version to display both Fuse Library Version and Ceph's Version. It requires moving global_init() [1] to below the for loop, as the Ceph's version is printing and then exiting within global_init(). This results in an undefined behavior (not working as expected) for other option usages.

So I don't think it is a good idea bringing in the new issues for fixing this minor issue (--version).

[1] https://github.com/ceph/ceph/blob/master/src/ceph_fuse.cc#L86

Actions

Copy link