Project

General

Profile

Actions
Copy link

Feature #2290

closed

ObjectCacher: handle read/write errors

Added by Josh Durgin about 12 years ago. Updated almost 12 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Josh Durgin
Category:
ObjectCacher
Target version:
v0.47
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Currently the return value of the underlying read/write calls is ignored (I left TODO notes there). We should figure out the best way to handle these (mark buffer with the error and return it on next use? return error on next flush? something else?)

Actions
Copy link
 #1

Updated by Sage Weil about 12 years ago

  • Translation missing: en.field_position set to 1
Actions
Copy link
 #2

Updated by Sage Weil about 12 years ago

  • Translation missing: en.field_position deleted (1)
  • Translation missing: en.field_position set to 61
Actions
Copy link
 #3

Updated by Sage Weil almost 12 years ago

  • Translation missing: en.field_position deleted (74)
  • Translation missing: en.field_position set to 22
Actions
Copy link
 #4

Updated by Sage Weil almost 12 years ago

  • Translation missing: en.field_position deleted (26)
  • Translation missing: en.field_position set to 10
Actions
Copy link
 #5

Updated by Sage Weil almost 12 years ago

  • Translation missing: en.field_story_points set to 8
  • Translation missing: en.field_position deleted (19)
  • Translation missing: en.field_position set to 19
Actions
Copy link
 #6

Updated by Sage Weil almost 12 years ago

  • Target version set to v0.47
  • Translation missing: en.field_position deleted (19)
  • Translation missing: en.field_position set to 12
Actions
Copy link
 #7

Updated by Josh Durgin almost 12 years ago

  • Status changed from New to In Progress
  • Assignee set to Josh Durgin
Actions
Copy link
 #8

Updated by Josh Durgin almost 12 years ago

  • Status changed from In Progress to Fix Under Review

Forgot to update this before, but it's in wip-oc-error-handling.

Actions
Copy link
 #9

Updated by Greg Farnum almost 12 years ago

This looks okay to me, although I didn't check it for comprehensive-ness (just looked at the diff).

Actions
Copy link
 #10

Updated by Josh Durgin almost 12 years ago

  • Status changed from Fix Under Review to In Progress

Sage actually reviewed this a while ago, and I was changing it to separate the read/write errors and not return the write errors for reads.

Actions
Copy link
 #11

Updated by Sage Weil almost 12 years ago

  • Target version changed from v0.47 to v0.48
Actions
Copy link
 #12

Updated by Josh Durgin almost 12 years ago

  • Status changed from In Progress to Fix Under Review

Updated wip-oc-error-handling to use a separate BufferHead state for read errors, and just reset the state to dirty on write errors.

Actions
Copy link
 #13

Updated by Josh Durgin almost 12 years ago

  • Status changed from Fix Under Review to Resolved
Actions
Copy link
 #14

Updated by Sage Weil almost 12 years ago

  • Translation missing: en.field_position deleted (34)
  • Translation missing: en.field_position set to 40
Actions
Copy link
 #15

Updated by Sage Weil almost 12 years ago

  • Target version changed from v0.48 to v0.47
  • Translation missing: en.field_position deleted (40)
  • Translation missing: en.field_position set to 1
  • Translation missing: en.field_position changed from 1 to 1251
Actions
Copy link

Also available in: Atom PDF