Project

General

Profile

Feature #2290

ObjectCacher: handle read/write errors

Added by Josh Durgin almost 9 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
ObjectCacher
Target version:
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Currently the return value of the underlying read/write calls is ignored (I left TODO notes there). We should figure out the best way to handle these (mark buffer with the error and return it on next use? return error on next flush? something else?)

History

#1 Updated by Sage Weil almost 9 years ago

  • translation missing: en.field_position set to 1

#2 Updated by Sage Weil almost 9 years ago

  • translation missing: en.field_position deleted (1)
  • translation missing: en.field_position set to 61

#3 Updated by Sage Weil over 8 years ago

  • translation missing: en.field_position deleted (74)
  • translation missing: en.field_position set to 22

#4 Updated by Sage Weil over 8 years ago

  • translation missing: en.field_position deleted (26)
  • translation missing: en.field_position set to 10

#5 Updated by Sage Weil over 8 years ago

  • translation missing: en.field_story_points set to 8
  • translation missing: en.field_position deleted (19)
  • translation missing: en.field_position set to 19

#6 Updated by Sage Weil over 8 years ago

  • Target version set to v0.47
  • translation missing: en.field_position deleted (19)
  • translation missing: en.field_position set to 12

#7 Updated by Josh Durgin over 8 years ago

  • Status changed from New to In Progress
  • Assignee set to Josh Durgin

#8 Updated by Josh Durgin over 8 years ago

  • Status changed from In Progress to Fix Under Review

Forgot to update this before, but it's in wip-oc-error-handling.

#9 Updated by Greg Farnum over 8 years ago

This looks okay to me, although I didn't check it for comprehensive-ness (just looked at the diff).

#10 Updated by Josh Durgin over 8 years ago

  • Status changed from Fix Under Review to In Progress

Sage actually reviewed this a while ago, and I was changing it to separate the read/write errors and not return the write errors for reads.

#11 Updated by Sage Weil over 8 years ago

  • Target version changed from v0.47 to v0.48

#12 Updated by Josh Durgin over 8 years ago

  • Status changed from In Progress to Fix Under Review

Updated wip-oc-error-handling to use a separate BufferHead state for read errors, and just reset the state to dirty on write errors.

#13 Updated by Josh Durgin over 8 years ago

  • Status changed from Fix Under Review to Resolved

#14 Updated by Sage Weil over 8 years ago

  • translation missing: en.field_position deleted (34)
  • translation missing: en.field_position set to 40

#15 Updated by Sage Weil over 8 years ago

  • Target version changed from v0.48 to v0.47
  • translation missing: en.field_position deleted (40)
  • translation missing: en.field_position set to 1
  • translation missing: en.field_position changed from 1 to 1251

Also available in: Atom PDF