Project

General

Profile

Bug #22872

"rbd trash purge --threshold" should support data pool

Added by Jason Dillaman almost 5 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
mimic
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Currently only the base pool is used for calculating usage.


Related issues

Copied to rbd - Backport #24476: mimic: "rbd trash purge --threshold" should support data pool Resolved

History

#1 Updated by Rishabh Dave almost 5 years ago

I look forward to try fixing this bug? Can I get a recipe to reproduce the bug?

#2 Updated by Jason Dillaman almost 5 years ago

Create and fill images that utilize a data pool (i.e. rbd create --size 10G --data-pool=datapool rbd/image). If you move those images to the trash and attempt to delete them using a purge threshold, only the "rbd" pool utilization will be checked instead of the "datapool" pool.

#3 Updated by Rishabh Dave almost 5 years ago

Well, what's the difference between the base pool and the data pool? I did couldn't find anything that would tell me the difference between these in docs, source code and web. Is it, somehow, related to tiering?

And, ideally it should check for both of them or either (depending on the user/situation)?

#4 Updated by Jason Dillaman almost 5 years ago

It's related to where the image data is stored -- which would be the bulk storage usage source for a trashed image.

#5 Updated by Mahati Chamarthy over 4 years ago

Does it mean support an option like:

rbd trash purge <pool-name> --threshold '<x>' --data-pool=<data-pool-name>

..and it looks for pool utilization in <data-pool-name> as that would be the source for trashed images?

#6 Updated by Jason Dillaman over 4 years ago

@Mahati: I would think it should just be implicit. It could loop through all the trashed images whose deferment end time is in the past and compute a set of (data) pools in-use by the images. For each pool in the set, delete trashed images in that (data) pool until that pool's threshold is met.

#7 Updated by Jason Dillaman over 4 years ago

  • Status changed from New to Fix Under Review

#8 Updated by Jason Dillaman over 4 years ago

  • Backport set to mimic

#9 Updated by Jason Dillaman over 4 years ago

  • Status changed from Fix Under Review to Pending Backport

#10 Updated by Nathan Cutler over 4 years ago

  • Copied to Backport #24476: mimic: "rbd trash purge --threshold" should support data pool added

#11 Updated by Nathan Cutler over 4 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF