Project

General

Profile

Bug #22273

Duplicate logrotate entries (AGAIN!) when upgrading from Ceph Jewel to Ceph Luminous (Debian)

Added by Fabian Gr├╝nbichler over 2 years ago. Updated 7 months ago.

Status:
Can't reproduce
Priority:
Urgent
Assignee:
-
Category:
-
Target version:
% Done:

0%

Source:
Community (dev)
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

The Jewel fix for http://tracker.ceph.com/issues/19938 (http://tracker.ceph.com/issues/20316) is broken and installs the logrotate file as /etc/logrotate.d/ceph-common.logrotate instead of /etc/logrotate.d/ceph-common (like Ceph Luminous and Debian packages do).

So now we have another variant of the original issue that this was supposed to fix, affecting all upgrades from Jewel 10.2.10 to Luminous.

I am unsure of how to cleanly get out of this mess, but I think we probably need another rm_conffile in master and luminous, and might want to move and rm_conffile in 10.2.11 as well?

History

#1 Updated by Sage Weil over 2 years ago

  • Priority changed from Normal to Urgent

#2 Updated by Robert Sander about 2 years ago

I see this on Ubuntu xenial with Ceph 12.2.5 packages from the Ceph repos:

root@ceph01:/etc/logrotate.d# dpkg -S /etc/logrotate.d/ceph-common
ceph-common: /etc/logrotate.d/ceph-common
root@ceph01:/etc/logrotate.d# dpkg -S /etc/logrotate.d/ceph
ceph: /etc/logrotate.d/ceph
root@ceph01:/etc/logrotate.d# dpkg -S /etc/logrotate.d/ceph-common.logrotate 
ceph-base: /etc/logrotate.d/ceph-common.logrotate

All three logrotate config files define /var/log/ceph/*.log as logfile pattern:

root@ceph01:/etc/logrotate.d# grep \{$ ceph*
ceph:/var/log/ceph/*.log {
ceph-common:/var/log/ceph/*.log {
ceph-common.logrotate:/var/log/ceph/*.log {

This should be unified.

#3 Updated by Sage Weil 7 months ago

  • Status changed from New to Can't reproduce

on both of my debian clusters i see a single /etc/logrotate.d/ceph-commnon; both of these clusters have been upgraded a zillion times.

if this is still a problem, please reopen and help debug this! thanks-

Also available in: Atom PDF