Project

General

Profile

Actions

Bug #22207

closed

ceph-disk flake8 test fails on very old, and very new, versions of flake8

Added by Nathan Cutler over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
luminous,jewel
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Very old, and very new, versions of flake8 treat E722 as an error:

flake8 runtests: commands[0] | flake8 --ignore=H105,H405,E127 ceph_disk tests
ceph_disk/main.py:1575:9: E722 do not use bare except'
ceph_disk/main.py:1582:9: E722 do not use bare except'
ceph_disk/main.py:3252:5: E722 do not use bare except'
ceph_disk/main.py:3288:21: E722 do not use bare except'
ceph_disk/main.py:3296:17: E722 do not use bare except'
ceph_disk/main.py:4358:5: E722 do not use bare except'
tests/test_main.py:26:1: E722 do not use bare except'
ERROR: InvocationError: '/opt/j/ws/mkck/src/ceph-disk/.tox/flake8/bin/flake8 --ignore=H105,H405,E127 ceph_disk tests'

(This does not happen when running make check via Jenkins, but it should be very easy to reproduce using different versions of flake8.)

References: https://gitlab.com/pycqa/flake8/issues/361


Related issues 2 (0 open2 closed)

Copied to Ceph - Backport #22235: luminous: ceph-disk flake8 test fails on very old, and very new, versions of flake8ResolvedNathan CutlerActions
Copied to Ceph - Backport #22236: jewel: ceph-disk flake8 test fails on very old, and very new, versions of flake8ResolvedNathan CutlerActions
Actions #1

Updated by Nathan Cutler over 6 years ago

  • Description updated (diff)
Actions #2

Updated by Nathan Cutler over 6 years ago

  • Backport set to luminous,jewel
Actions #3

Updated by Nathan Cutler over 6 years ago

  • Description updated (diff)
Actions #4

Updated by Nathan Cutler over 6 years ago

  • Status changed from New to Fix Under Review
Actions #5

Updated by Kefu Chai over 6 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #6

Updated by Nathan Cutler over 6 years ago

  • Copied to Backport #22235: luminous: ceph-disk flake8 test fails on very old, and very new, versions of flake8 added
Actions #7

Updated by Nathan Cutler over 6 years ago

  • Copied to Backport #22236: jewel: ceph-disk flake8 test fails on very old, and very new, versions of flake8 added
Actions #8

Updated by Nathan Cutler over 6 years ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF