Feature #21888: Adding [--repair] option for cephfs-journal-tool make it can recover all journal as much as possible. - CephFS - Ceph

Actions

Copy link

Feature #21888

open

Adding [--repair] option for cephfs-journal-tool make it can recover all journal as much as possible.

Added by Ivan Guan over 6 years ago. Updated over 4 years ago.

Status:

Fix Under Review

Priority:

High

Assignee:

Ivan Guan

Category:

Target version:

% Done:

Source:

Community (user)

Tags:

Backport:

Reviewed:

Affected Versions:

Component(FS):

tools

Labels (FS):

Pull request ID:

18465

Description

As described in the document if a journal is damaged or for any reason an MDS is incapable of replaying it, attempt to recover what file metadata we can like so:
"cephfs-journal-tool event recover_dentries summary". I found a risk when research related code rencently which may lost journal log if it's damaged.The worse
case is if the length of journal is corrupt we may lost many journal.

Sample Graph

Of course if a journal data is corrupt we can throw it away, but if only the length or trailling is corrupt we should repair it as much as possible, in case of losting event.

Files

Download all files

journal_scan.1.png (4.04 KB) journal_scan.1.png		Ivan Guan, 10/22/2017 06:04 AM
journal_scan.2.png (11.3 KB) journal_scan.2.png		Ivan Guan, 10/22/2017 06:04 AM