Project

General

Profile

Feature #21305

Just discard changed data since snapshot in "rbd rollback" command

Added by Марк Коренберг about 3 years ago. Updated almost 3 years ago.

Status:
Rejected
Priority:
Normal
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Rolling back images is painfully slow. Yes, I know, "rbd clone", but this creates another image and automatic-snapshotting-backuppers get failed.

Why not to bring image to the state of specified snapshot ?

History

#1 Updated by Jason Dillaman almost 3 years ago

  • Project changed from Ceph to rbd
  • Subject changed from Just discard changed data since snapshot in "rbd roollback" command to Just discard changed data since snapshot in "rbd rollback" command

Only possible if you are rolling back to the most recent snapshot. If you are rolling back to an older snapshot, you would need to copy the older data to the HEAD revision instead of just deleting the HEAD revision to expose the most recent snapshot.

#2 Updated by Марк Коренберг almost 3 years ago

Yes, ability to do FAST rollback to latest snapshot will be huge improvement, IMHO.

#3 Updated by Jason Dillaman almost 3 years ago

  • Status changed from New to In Progress
  • Assignee set to Jason Dillaman

#4 Updated by Jason Dillaman almost 3 years ago

  • Status changed from In Progress to Rejected

I quickly hacked this up and it turns out the OSDs don't actually allow you to do this. The low-level, internal transactions within the OSD will still clone the HEAD object and then "delete" it, which results in a zeroed object at HEAD.

#5 Updated by Марк Коренберг almost 3 years ago

I don't understand cause why this would not be implemented. Maybe open this issue until someone be able to fix it ?

#6 Updated by Jason Dillaman almost 3 years ago

There is nothing RBD can do -- you can perhaps open a new ticket against RADOS to optimize snap rollback directly.

Also available in: Atom PDF