Project

General

Profile

Actions

Bug #2129

open

ceph: xattr: call __build_xattrs() *before* cap check

Added by Alex Elder about 12 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
Severity:
Reviewed:
Affected Versions:
ceph-qa-suite:
Crash signature (v1):
Crash signature (v2):

Description

While reviewing a change to the xattr code, Sage noticed that some
calls to __build_xattrs() were being made after having completed
a capability check. Since __build_xattrs() drops i_ceph_lock,
the earlier capability checks may no longer be valid. (At least
I think that's the problem--Sage, please correct me if I'm wrong.)

So these checks need to be moved so they're done in a safe way.

In his review, Sage said he thought the proposed change could go
in and this fix be done separately, so I'm documenting this here.

No data to display

Actions

Also available in: Atom PDF