Project

General

Profile

Bug #21162

'osd crush rule rename' not idempotent

Added by Sage Weil about 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
-
Target version:
-
Start date:
08/28/2017
Due date:
% Done:

0%

Source:
Tags:
Backport:
luminous
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(RADOS):
Pull request ID:

Description

2017-08-27T08:03:51.168 INFO:tasks.workunit.client.0.smithi177.stderr:+ ceph osd crush rule rename foo-asdf foo
2017-08-27T08:03:51.170 INFO:tasks.workunit.client.0.smithi177.stderr:2017-08-27 08:03:51.119902 7fd726d3e700 -1 WARNING: all dangerous and experimental features are enabled.
2017-08-27T08:03:51.172 INFO:tasks.workunit.client.0.smithi177.stderr:2017-08-27 08:03:51.151101 7fd726d3e700 -1 WARNING: all dangerous and experimental features are enabled.
2017-08-27T08:03:51.175 INFO:teuthology.orchestra.run.smithi110:Running: 'sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 120 ceph --cluster ceph -m 172.21.15.177:6789 mon_status'
2017-08-27T08:03:51.304 INFO:teuthology.orchestra.run.smithi110.stderr:2017-08-27 08:03:51.303084 7f6d70176700 -1 WARNING: all dangerous and experimental features are enabled.
2017-08-27T08:03:51.324 INFO:teuthology.orchestra.run.smithi110.stderr:2017-08-27 08:03:51.323140 7f6d70176700 -1 WARNING: all dangerous and experimental features are enabled.
2017-08-27T08:03:51.472 INFO:teuthology.orchestra.run.smithi110.stdout:{"name":"f","rank":1,"state":"peon","election_epoch":16,"quorum":[0,1,2,3,4,5,6,7,8],"features":{"required_con":"153140804152475648","required_mon":["kraken","luminous"],"quorum_con":"2305244844532236283","quorum_mon":["kraken","luminous"]},"outside_quorum":[],"extra_probe_peers":[],"sync_provider":[],"monmap":{"epoch":1,"fsid":"f6d246eb-30db-4ade-87f8-c6b64001355a","modified":"2017-08-27 08:00:09.142921","created":"2017-08-27 08:00:09.142921","features":{"persistent":["kraken","luminous"],"optional":[]},"mons":[{"rank":0,"name":"a","addr":"172.21.15.110:6789/0","public_addr":"172.21.15.110:6789/0"},{"rank":1,"name":"f","addr":"172.21.15.177:6789/0","public_addr":"172.21.15.177:6789/0"},{"rank":2,"name":"b","addr":"172.21.15.110:6790/0","public_addr":"172.21.15.110:6790/0"},{"rank":3,"name":"g","addr":"172.21.15.177:6790/0","public_addr":"172.21.15.177:6790/0"},{"rank":4,"name":"c","addr":"172.21.15.110:6791/0","public_addr":"172.21.15.110:6791/0"},{"rank":5,"name":"h","addr":"172.21.15.177:6791/0","public_addr":"172.21.15.177:6791/0"},{"rank":6,"name":"d","addr":"172.21.15.110:6792/0","public_addr":"172.21.15.110:6792/0"},{"rank":7,"name":"i","addr":"172.21.15.177:6792/0","public_addr":"172.21.15.177:6792/0"},{"rank":8,"name":"e","addr":"172.21.15.110:6793/0","public_addr":"172.21.15.110:6793/0"}]},"feature_map":{"mon":{"group":{"features":"0x1ffddff8eea4fffb","release":"luminous","num":1}},"osd":{"group":{"features":"0x1ffddff8eea4fffb","release":"luminous","num":2}},"client":{"group":{"features":"0x1ffddff8eea4fffb","release":"luminous","num":2}}}}
2017-08-27T08:03:51.475 INFO:teuthology.orchestra.run.smithi110:Running: 'sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 120 ceph --cluster ceph -m 172.21.15.177:6790 mon_status'
2017-08-27T08:03:51.594 INFO:teuthology.orchestra.run.smithi110.stderr:2017-08-27 08:03:51.593162 7f85a44d2700 -1 WARNING: all dangerous and experimental features are enabled.
2017-08-27T08:03:51.613 INFO:teuthology.orchestra.run.smithi110.stderr:2017-08-27 08:03:51.612063 7f85a44d2700 -1 WARNING: all dangerous and experimental features are enabled.
2017-08-27T08:03:51.750 INFO:teuthology.orchestra.run.smithi110.stdout:{"name":"g","rank":3,"state":"peon","election_epoch":16,"quorum":[0,1,2,3,4,5,6,7,8],"features":{"required_con":"153140804152475648","required_mon":["kraken","luminous"],"quorum_con":"2305244844532236283","quorum_mon":["kraken","luminous"]},"outside_quorum":[],"extra_probe_peers":[],"sync_provider":[],"monmap":{"epoch":1,"fsid":"f6d246eb-30db-4ade-87f8-c6b64001355a","modified":"2017-08-27 08:00:09.142921","created":"2017-08-27 08:00:09.142921","features":{"persistent":["kraken","luminous"],"optional":[]},"mons":[{"rank":0,"name":"a","addr":"172.21.15.110:6789/0","public_addr":"172.21.15.110:6789/0"},{"rank":1,"name":"f","addr":"172.21.15.177:6789/0","public_addr":"172.21.15.177:6789/0"},{"rank":2,"name":"b","addr":"172.21.15.110:6790/0","public_addr":"172.21.15.110:6790/0"},{"rank":3,"name":"g","addr":"172.21.15.177:6790/0","public_addr":"172.21.15.177:6790/0"},{"rank":4,"name":"c","addr":"172.21.15.110:6791/0","public_addr":"172.21.15.110:6791/0"},{"rank":5,"name":"h","addr":"172.21.15.177:6791/0","public_addr":"172.21.15.177:6791/0"},{"rank":6,"name":"d","addr":"172.21.15.110:6792/0","public_addr":"172.21.15.110:6792/0"},{"rank":7,"name":"i","addr":"172.21.15.177:6792/0","public_addr":"172.21.15.177:6792/0"},{"rank":8,"name":"e","addr":"172.21.15.110:6793/0","public_addr":"172.21.15.110:6793/0"}]},"feature_map":{"mon":{"group":{"features":"0x1ffddff8eea4fffb","release":"luminous","num":1}},"osd":{"group":{"features":"0x1ffddff8eea4fffb","release":"luminous","num":2}},"client":{"group":{"features":"0x1ffddff8eea4fffb","release":"luminous","num":2}}}}
2017-08-27T08:03:51.755 INFO:teuthology.orchestra.run.smithi110:Running: 'sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 120 ceph --cluster ceph -m 172.21.15.177:6791 mon_status'
2017-08-27T08:03:51.860 INFO:teuthology.orchestra.run.smithi110.stderr:2017-08-27 08:03:51.859730 7fa61753c700 -1 WARNING: all dangerous and experimental features are enabled.
2017-08-27T08:03:51.870 INFO:teuthology.orchestra.run.smithi110.stderr:2017-08-27 08:03:51.865685 7fa61753c700 -1 WARNING: all dangerous and experimental features are enabled.
2017-08-27T08:03:51.987 INFO:teuthology.orchestra.run.smithi110.stdout:{"name":"h","rank":5,"state":"peon","election_epoch":16,"quorum":[0,1,2,3,4,5,6,7,8],"features":{"required_con":"153140804152475648","required_mon":["kraken","luminous"],"quorum_con":"2305244844532236283","quorum_mon":["kraken","luminous"]},"outside_quorum":[],"extra_probe_peers":[],"sync_provider":[],"monmap":{"epoch":1,"fsid":"f6d246eb-30db-4ade-87f8-c6b64001355a","modified":"2017-08-27 08:00:09.142921","created":"2017-08-27 08:00:09.142921","features":{"persistent":["kraken","luminous"],"optional":[]},"mons":[{"rank":0,"name":"a","addr":"172.21.15.110:6789/0","public_addr":"172.21.15.110:6789/0"},{"rank":1,"name":"f","addr":"172.21.15.177:6789/0","public_addr":"172.21.15.177:6789/0"},{"rank":2,"name":"b","addr":"172.21.15.110:6790/0","public_addr":"172.21.15.110:6790/0"},{"rank":3,"name":"g","addr":"172.21.15.177:6790/0","public_addr":"172.21.15.177:6790/0"},{"rank":4,"name":"c","addr":"172.21.15.110:6791/0","public_addr":"172.21.15.110:6791/0"},{"rank":5,"name":"h","addr":"172.21.15.177:6791/0","public_addr":"172.21.15.177:6791/0"},{"rank":6,"name":"d","addr":"172.21.15.110:6792/0","public_addr":"172.21.15.110:6792/0"},{"rank":7,"name":"i","addr":"172.21.15.177:6792/0","public_addr":"172.21.15.177:6792/0"},{"rank":8,"name":"e","addr":"172.21.15.110:6793/0","public_addr":"172.21.15.110:6793/0"}]},"feature_map":{"mon":{"group":{"features":"0x1ffddff8eea4fffb","release":"luminous","num":1}},"client":{"group":{"features":"0x1ffddff8eea4fffb","release":"luminous","num":1}}}}
2017-08-27T08:03:51.991 INFO:teuthology.orchestra.run.smithi110:Running: 'sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 120 ceph --cluster ceph -m 172.21.15.177:6792 mon_status'
2017-08-27T08:03:52.097 INFO:teuthology.orchestra.run.smithi110.stderr:2017-08-27 08:03:52.096262 7f1f9d07c700 -1 WARNING: all dangerous and experimental features are enabled.
2017-08-27T08:03:52.122 INFO:teuthology.orchestra.run.smithi110.stderr:2017-08-27 08:03:52.115255 7f1f9d07c700 -1 WARNING: all dangerous and experimental features are enabled.
2017-08-27T08:03:52.227 INFO:teuthology.orchestra.run.smithi110.stdout:{"name":"i","rank":7,"state":"peon","election_epoch":16,"quorum":[0,1,2,3,4,5,6,7,8],"features":{"required_con":"153140804152475648","required_mon":["kraken","luminous"],"quorum_con":"2305244844532236283","quorum_mon":["kraken","luminous"]},"outside_quorum":[],"extra_probe_peers":[],"sync_provider":[],"monmap":{"epoch":1,"fsid":"f6d246eb-30db-4ade-87f8-c6b64001355a","modified":"2017-08-27 08:00:09.142921","created":"2017-08-27 08:00:09.142921","features":{"persistent":["kraken","luminous"],"optional":[]},"mons":[{"rank":0,"name":"a","addr":"172.21.15.110:6789/0","public_addr":"172.21.15.110:6789/0"},{"rank":1,"name":"f","addr":"172.21.15.177:6789/0","public_addr":"172.21.15.177:6789/0"},{"rank":2,"name":"b","addr":"172.21.15.110:6790/0","public_addr":"172.21.15.110:6790/0"},{"rank":3,"name":"g","addr":"172.21.15.177:6790/0","public_addr":"172.21.15.177:6790/0"},{"rank":4,"name":"c","addr":"172.21.15.110:6791/0","public_addr":"172.21.15.110:6791/0"},{"rank":5,"name":"h","addr":"172.21.15.177:6791/0","public_addr":"172.21.15.177:6791/0"},{"rank":6,"name":"d","addr":"172.21.15.110:6792/0","public_addr":"172.21.15.110:6792/0"},{"rank":7,"name":"i","addr":"172.21.15.177:6792/0","public_addr":"172.21.15.177:6792/0"},{"rank":8,"name":"e","addr":"172.21.15.110:6793/0","public_addr":"172.21.15.110:6793/0"}]},"feature_map":{"mon":{"group":{"features":"0x1ffddff8eea4fffb","release":"luminous","num":1}},"osd":{"group":{"features":"0x1ffddff8eea4fffb","release":"luminous","num":1}},"client":{"group":{"features":"0x1ffddff8eea4fffb","release":"luminous","num":1}}}}
2017-08-27T08:03:52.236 INFO:tasks.mon_thrash.mon_thrasher:monitors to thrash: ['i', 'e', 'd']
2017-08-27T08:03:52.243 INFO:tasks.mon_thrash.mon_thrasher:monitors to freeze: []
2017-08-27T08:03:52.259 INFO:tasks.mon_thrash.mon_thrasher:thrashing mon.i
2017-08-27T08:03:52.264 INFO:tasks.mon_thrash.mon_thrasher:killing mon.i
2017-08-27T08:03:52.273 DEBUG:tasks.ceph.mon.i:waiting for process to exit
2017-08-27T08:03:52.279 INFO:teuthology.orchestra.run:waiting for 300
2017-08-27T08:03:52.288 INFO:tasks.ceph.mon.i:Stopped
2017-08-27T08:03:52.297 INFO:tasks.mon_thrash.mon_thrasher:thrashing mon.e
2017-08-27T08:03:52.306 INFO:tasks.mon_thrash.mon_thrasher:killing mon.e
2017-08-27T08:03:52.316 DEBUG:tasks.ceph.mon.e:waiting for process to exit
2017-08-27T08:03:52.319 INFO:teuthology.orchestra.run:waiting for 300
2017-08-27T08:03:52.339 INFO:tasks.ceph.mon.e:Stopped
2017-08-27T08:03:52.342 INFO:tasks.mon_thrash.mon_thrasher:thrashing mon.d
2017-08-27T08:03:52.344 INFO:tasks.mon_thrash.mon_thrasher:killing mon.d
2017-08-27T08:03:52.347 DEBUG:tasks.ceph.mon.d:waiting for process to exit
2017-08-27T08:03:52.349 INFO:teuthology.orchestra.run:waiting for 300
2017-08-27T08:03:52.385 INFO:tasks.ceph.mon.d:Stopped
2017-08-27T08:03:52.387 INFO:tasks.mon_thrash.ceph_manager:waiting for quorum size 6
2017-08-27T08:03:52.390 INFO:teuthology.orchestra.run.smithi110:Running: 'sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 120 ceph --cluster ceph quorum_status'
2017-08-27T08:03:52.554 INFO:teuthology.orchestra.run.smithi110.stderr:2017-08-27 08:03:52.552708 7fabb5fdc700 -1 WARNING: all dangerous and experimental features are enabled.
2017-08-27T08:03:52.574 INFO:teuthology.orchestra.run.smithi110.stderr:2017-08-27 08:03:52.572868 7fabb5fdc700 -1 WARNING: all dangerous and experimental features are enabled.
2017-08-27T08:03:52.577 INFO:teuthology.orchestra.run.smithi110.stderr:2017-08-27 08:03:52.576518 7fabac6f7700  0 -- 172.21.15.110:0/3752616705 >> 172.21.15.110:6793/0 pipe(0x7fabb011bc10 sd=9 :0 s=1 pgs=0 cs=0 l=1 c=0x7fabb00ecd70).fault
2017-08-27T08:04:02.578 INFO:teuthology.orchestra.run.smithi110.stderr:2017-08-27 08:04:02.576813 7fabac4f5700  0 -- 172.21.15.110:0/3752616705 >> 172.21.15.177:6792/0 pipe(0x7fab90000e80 sd=10 :0 s=1 pgs=0 cs=0 l=1 c=0x7fab90002100).fault
2017-08-27T08:04:02.580 INFO:teuthology.orchestra.run.smithi110.stderr:2017-08-27 08:04:02.576821 7fabac6f7700  0 -- 172.21.15.110:0/3752616705 >> 172.21.15.110:6792/0 pipe(0x7fab900035c0 sd=9 :0 s=1 pgs=0 cs=0 l=1 c=0x7fab900048a0).fault
2017-08-27T08:04:05.579 INFO:teuthology.orchestra.run.smithi110.stderr:2017-08-27 08:04:05.577218 7fabac5f6700  0 -- 172.21.15.110:0/3752616705 >> 172.21.15.110:6793/0 pipe(0x7fab90008e30 sd=10 :0 s=1 pgs=0 cs=0 l=1 c=0x7fab9000a0b0).fault
2017-08-27T08:04:07.425 INFO:tasks.workunit.client.0.smithi177.stderr:Error ENOENT: source rule name 'foo-asdf' does not exist
2017-08-27T08:04:07.452 INFO:tasks.workunit:Stopping ['mon/pool_ops.sh', 'mon/crush_ops.sh', 'mon/osd.sh', 'mon/caps.sh'] on client.0...

you should be able to do
ceph osd crush rule rename a b
ceph osd crush rule rename a b

and get a success. which means basically if the src doesn't exist and the destination does we just blindly return true.

/a/sage-2017-08-27_02:16:57-rados-wip-sage-testing2-20170825a-distro-basic-smithi/1568951


Related issues

Copied to RADOS - Backport #21182: luminous: 'osd crush rule rename' not idempotent Resolved

History

#1 Updated by xie xingguo about 2 years ago

  • Status changed from Verified to Need Review

#2 Updated by Sage Weil about 2 years ago

  • Status changed from Need Review to Pending Backport
  • Backport set to luminous

#3 Updated by Nathan Cutler about 2 years ago

  • Copied to Backport #21182: luminous: 'osd crush rule rename' not idempotent added

#4 Updated by Nathan Cutler about 2 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF