Project

General

Profile

Bug #20991

S3 API Policy Conditions IpAddress and NotIpAddress do not work

Added by John Gibson over 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
luminous
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

There are several bugs in the implementation of the IpAddress and NotIpAddress conditions of the S3 API that cause them to simply not function. Among other issues the as_network() function always returns none, even if the IpAddress is parsed correctly. There are also issues with byte ordering and using the wrong structs during conversion, etc.


Related issues

Copied to rgw - Backport #22601: luminous: S3 API Policy Conditions IpAddress and NotIpAddress do not work Resolved

History

#1 Updated by John Gibson over 5 years ago

I've submitted a pull request that fixes the issue along with some basic unit tests: https://github.com/ceph/ceph/pull/17010

#2 Updated by Matt Benjamin over 5 years ago

  • Status changed from New to Fix Under Review
  • Assignee set to Adam Emerson
  • Backport set to luminous

#3 Updated by Adam Emerson almost 5 years ago

  • Status changed from Fix Under Review to 7

#4 Updated by Adam Emerson almost 5 years ago

  • Copied to Backport #22601: luminous: S3 API Policy Conditions IpAddress and NotIpAddress do not work added

#5 Updated by Adam Emerson almost 5 years ago

  • Status changed from 7 to Pending Backport

#6 Updated by Nathan Cutler almost 5 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF