Actions
Bug #20899
closedprometheus module generates invalid output when counter names contain non-alphanum characters
Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
prometheus module
Target version:
-
% Done:
0%
Source:
Tags:
Backport:
luminous
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
When I enabled an MDS, I found that prometheus threw an error scraping our stats. I assume it's due to counter names (maybe the ones that have a plus/minus sign in them?)
Updated by Jeremy Austin over 6 years ago
I created an account just so I could submit this bug… so I concur,
mds_mem_cap+ is an example (the first sequentially) of one on which prometheus choked.
I propose:
https://github.com/ceph/ceph/compare/master...jermudgeon:patch-1
Updated by John Spray over 6 years ago
- Status changed from New to Fix Under Review
- Backport set to luminous
Thanks for the patch, I took the liberty of turning it into a pull request here:
Updated by Jeremy Austin over 6 years ago
Thanks, John — I wasn't sure which branch to create the pull request on, luminous or master. Be gentle with me, it's my first time :)
Updated by John Spray over 6 years ago
- Status changed from Fix Under Review to Pending Backport
Updated by Nathan Cutler over 6 years ago
- Copied to Backport #21452: luminous: prometheus module generates invalid output when counter names contain non-alphanum characters added
Updated by John Spray about 6 years ago
- Status changed from Pending Backport to Resolved
Actions