Project

General

Profile

Bug #20790

ceph logs shouldn't display dmcrypt key

Added by Brad Hubbard almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
common
Target version:
-
% Done:

0%

Source:
Support
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

2017-07-05 12:59:20.917401 mon.0 [INF] from='client.? 192.168.122.100:0/1418962056' entity='client.bootstrap-osd' cmd=[{"prefix": "config-key put", "key": "dm-crypt/osd/db13f070-7e71-44ca-9b2a-c5c4d482a40a/luks", "val": "DqcGGR1PT9j0z5AenpmSirK2b1J6gE13lN5m1YcYL6/nqTUgqdtJrYblLXdIv7awO6eL0PIIsfybmNfdFsTNigA5cSuUEdw66ODtK8sasYZHlaVIuFVNmEAU0xy/1Xhj+nKzAMVGjrZtUZnQ9kdJMJAbjvtLsV8CVQIcNE4G4Fg="}]: dispatch
2017-07-05 12:59:20.920841 mon.0 [INF] from='client.? 192.168.122.100:0/1418962056' entity='client.bootstrap-osd' cmd='[{"prefix": "config-key put", "key": "dm-crypt/osd/db13f070-7e71-44ca-9b2a-c5c4d482a40a/luks", "val": "DqcGGR1PT9j0z5AenpmSirK2b1J6gE13lN5m1YcYL6/nqTUgqdtJrYblLXdIv7awO6eL0PIIsfybmNfdFsTNigA5cSuUEdw66ODtK8sasYZHlaVIuFVNmEAU0xy/1Xhj+nKzAMVGjrZtUZnQ9kdJMJAbjvtLsV8CVQIcNE4G4Fg="}]': finished

Steps to Reproduce:
1. ceph-disk prepare --dmcrypt <device>

Minimal Reproducer:

ceph config-key put dm-crypt/osd/db13f070-7e71-44ca-9b2a-c5c4d482a40a/luks DqcGGR1PT9j0z5AenpmSirK2b1J6gE13lN5m1YcYL6/nqTUgqdtJrYblLXdIv7awO6eL0PIIsfybmNfdFsTNigA5cSuUEdw66ODtK8sasYZ
HlaVIuFVNmEAU0xy/1Xhj+nKzAMVGjrZtUZnQ9kdJMJAbjvtLsV8CVQIcNE4G4Fg=

https://github.com/ceph/ceph/pull/16619


Related issues

Related to Ceph - Backport #21059: jewel: ceph-disk should use stdin for 'config-key put' command Resolved

History

#1 Updated by Brad Hubbard almost 3 years ago

  • Description updated (diff)

#2 Updated by Brad Hubbard almost 3 years ago

  • Description updated (diff)
  • Status changed from New to In Progress

#3 Updated by Sage Weil almost 3 years ago

The 'config-key put' command can also take the value via stdin (-i -) or a file (-i <filename>); if the caller just does that this problem goes away.

Also, in luminous, this key is provided via 'osd new' and 'config-key put' isn't used at all anymore. For jewel, a minimal fix is probably just the above...

#4 Updated by Brad Hubbard almost 3 years ago

  • Status changed from In Progress to Closed

#5 Updated by Brad Hubbard almost 3 years ago

  • Related to Backport #21059: jewel: ceph-disk should use stdin for 'config-key put' command added

Also available in: Atom PDF