Project

General

Profile

Actions

Bug #20707

closed

CMake distutil module forces Python projects to have useless files

Added by Alfredo Deza almost 7 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
build
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

I am in the process of creating a new Python component in Ceph and I've been forced to add these:

README.rst, requirements.txt, test-requirements.txt

Because the module wants them:

set(py_srcs setup.py README.rst requirements.txt test-requirements.txt ${name})

The build fails if any of those aren't present, like

[  4%] [  4%] make[2]: *** No rule to make target `../src/ceph-volume/requirements.txt', needed by `src/ceph-volume/requirements.txt'.  Stop.

It is absolutely unnecessary to require a `test-requirements.txt` and a `requirements.txt`. If some other Ceph component wishes to include those, then it should
be up to that component to find a way to include them and not force everything else to add empty files to be able to build Ceph.

Actions #1

Updated by Dan Mick almost 7 years ago

Proposed a fix at https://github.com/dmick/ceph/commit/0196b31e3c7ea0855a5160590cc167432c23a1b4; don't know if it worked for you alfredo

Actions #2

Updated by Alfredo Deza over 6 years ago

Dan's fix totally worked for me. Cherry-picked the commit and using it in the branch.

sha1 of commit: 597f34d0d0b653d6e0136b50333811ce370d5349

Leaving open until `wip-volume` gets merged

Actions #3

Updated by Alfredo Deza over 6 years ago

  • Status changed from New to Resolved
Actions

Also available in: Atom PDF