Project

General

Profile

Cleanup #20604

startsync can be removed

Added by Ilya Dryomov about 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
fs/ceph
Target version:
-
Start date:
07/12/2017
Due date:
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:

Description

<sage> btw i just noticed kclient is still sending write,startsync .. that startsync is a no-op (has been for years) and can probably be removed

0001-ceph-kernel-client-startsync-can-be-removed.patch View (4.27 KB) Yanhu Cao, 07/20/2017 02:33 AM

History

#1 Updated by Amit Kumar about 2 years ago

I believe you are talking about OP_STARTSYNC = 27, // start a sync
present inside class ObjectStore::Transaction

#3 Updated by Jos Collin about 2 years ago

  • Status changed from New to In Progress

#4 Updated by Ilya Dryomov about 2 years ago

This ticket is for the kernel client -- don't close until it's done there as well.

#5 Updated by Jos Collin about 2 years ago

@Ilya: Yes we are aware of that.

#6 Updated by Sage Weil about 2 years ago

  • Assignee set to Amit Kumar

#7 Updated by Yanhu Cao about 2 years ago

I use ceph-client master branch to fix this, see attachment.

#8 Updated by Ilya Dryomov about 2 years ago

Kernel client should be sent to ceph-devel as plain text.

I took a quick look, in ceph_direct_read_write() you removed the "/*include a 'startsync' command*/" comment, but ceph_osdc_new_request() is still called with num_ops == 2 for writes, reserving a slot for startsync op.

#9 Updated by Yanhu Cao about 2 years ago

@Ilya: OK, I'll check again

#10 Updated by Jos Collin about 2 years ago

PR: https://github.com/ceph/ceph/pull/16396 is merged. This tracker is now waiting for the kclient to be fixed.

#11 Updated by Ilya Dryomov about 2 years ago

  • Status changed from In Progress to Resolved

The kernel client patch is in 4.14 queue.

Also available in: Atom PDF