Project

General

Profile

Actions

Bug #20488

closed

ceph-disk dmcrypt does not unlock blockdevice for bluestore

Added by Felix Winterhalter almost 7 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Urgent
Category:
OSD
Target version:
-
% Done:

0%

Source:
Community (user)
Tags:
Backport:
luminous
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
ceph-disk
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

The ceph-disk utility does not unlock the blockdevice when called with --dmcrypt for bluestore.

It will unlock the osd data directory alright using the lockbox but then neglect to unlock the blockdevice itself. Causing the OSD to fail without access to the block device.

The fix should be simple enough by adding in a detection whether the block_dmcrypt link exists in the OSD directory and then proceed to unlock that. Alternatively check whether it is a bluestore OSD and then unlock the second partition using the same key.

I can prepare a pull request to solve that problem if wanted.


Related issues 1 (0 open1 closed)

Copied to Ceph - Backport #21974: luminous: ceph-disk dmcrypt does not unlock blockdevice for bluestoreResolvedKefu ChaiActions
Actions #1

Updated by Sage Weil almost 7 years ago

  • Status changed from New to 12
  • Priority changed from Normal to Urgent

A pull request fixing this would be most appreciated, thanks!

Actions #2

Updated by Kefu Chai almost 7 years ago

  • Status changed from 12 to Fix Under Review
  • Assignee set to Felix Winterhalter
Actions #3

Updated by Kefu Chai over 6 years ago

  • Status changed from Fix Under Review to Resolved
  • Target version deleted (v12.1.0)
Actions #4

Updated by Nathan Cutler over 6 years ago

  • Status changed from Resolved to Pending Backport
  • Backport set to luminous

This just missed the v12.2.0 cutoff. Kefu opened luminous backport PR: https://github.com/ceph/ceph/pull/18625

Actions #5

Updated by Nathan Cutler over 6 years ago

  • Copied to Backport #21974: luminous: ceph-disk dmcrypt does not unlock blockdevice for bluestore added
Actions #6

Updated by Nathan Cutler over 6 years ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF