Actions
Fix #20425
closedbuild/ops: rpm: some build dependencies are only needed for running "make check", not for the build itself
% Done:
0%
Source:
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
Some dependencies - notably the mgr dependencies "python-cherrypy", "python-pecan" and "python-werkzeug" - are only needed to run "make check". Since these dependencies bring in a pretty long list of packages (dependencies of dependencies of dependencies. . .) it would make sense to put them inside the "make_check" bcond so RPM builds that do not run "make check" (the default) would not pull in all these python modules that are not used.
There is one wrinkle, though: the bcond is "off" by default, so install-deps.sh will need to activate it before parsing the spec file for dependencies, otherwise "run-make-check.sh" will fail due to missing dependencies.
Updated by Nathan Cutler almost 7 years ago
- Status changed from New to Fix Under Review
Updated by Nathan Cutler almost 7 years ago
- Subject changed from build/ops: rpm: some build dependencies are only needed for running "make check" to build/ops: rpm: some build dependencies are only needed for running "make check", not for the build itself
Updated by Nathan Cutler almost 6 years ago
- Status changed from Fix Under Review to Resolved
Actions