Project

General

Profile

Actions
Copy link

Fix #20246

closed

Make clog message on scrub errors friendlier.

Added by John Spray almost 7 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
John Spray
Category:
Administration/Usability
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Currently it looks something like this:

[WRN] Scrub error on inode [inode 10000000000 [...2,head] /foo/ auth v6 f(v0 m2017-06-11 11:39:48.327560 1=1+0) n(v0 rc2017-06-11 11:39:48.327560 b3 2=1+1) (inest lock) (ifile excl) (iversion lock) caps={4116=pAsLsXsFsx/-@0},l=4116 | dirfrag=0 caps=1 scrubqueue=0 0x5587d061be00] (/foo) see mds.a log for details

It makes me chuckle that we barf that much detail and then say "see mds.a.log for details".

The cluster log message should probably put the path first, put the inode number in brackets, and log all the rest to the local MDS log.

Actions
Copy link
 #1

Updated by John Spray almost 7 years ago

  • Status changed from New to In Progress
  • Assignee set to John Spray
Actions
Copy link
 #2

Updated by John Spray almost 7 years ago

  • Status changed from In Progress to Fix Under Review

This snowballed into me pondering about what clog messages really should look like (https://github.com/ceph/ceph/pull/16292) but the tweak to this particular one is in there too.

Actions
Copy link
 #3

Updated by Patrick Donnelly over 6 years ago

  • Status changed from Fix Under Review to Resolved
Actions
Copy link

Also available in: Atom PDF