Project

General

Profile

Bug #19958

missing i_nlink check while converting a file handle to dentry

Added by Luis Henriques over 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Normal
Category:
fs/ceph
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Crash signature (v1):
Crash signature (v2):

Description

xfstest generic/426 is failing due to a missing i_nlink check while converting a file handle to dentry. Here's the test output:

./check -d "generic/426" 
FSTYP         -- ceph
PLATFORM      -- Linux/x86_64 rapido1 4.12.0-rc1+

generic/426     
QA output created by 426
open_by_handle(326) opened an unlinked file!
open_by_handle(327) opened an unlinked file!
open_by_handle(363) opened an unlinked file!
open_by_handle(364) opened an unlinked file!
open_by_handle(365) opened an unlinked file!
[...]
Silence is golden
 - output mismatch (see /fstests/xfstests-dev/results//generic/426.out.bad)
    --- tests/generic/426.out   2017-05-03 10:19:33.000000000 +0000
    +++ /fstests/xfstests-dev/results//generic/426.out.bad      2017-05-17 11:08:46.015583521 +0000
    @@ -1,2 +1,700 @@
     QA output created by 426
    +open_by_handle(326) opened an unlinked file!
    +open_by_handle(327) opened an unlinked file!
    +open_by_handle(328) opened an unlinked file!
    +open_by_handle(329) opened an unlinked file!
    +open_by_handle(330) opened an unlinked file!
    +open_by_handle(331) opened an unlinked file!
    ...
    (Run 'diff -u tests/generic/426.out /fstests/xfstests-dev/results//generic/426.out.bad'  to see the entire diff)
Ran: generic/426
Failures: generic/426
Failed 1 of 1 tests

I've tested the attached patch and it fixes the issue.

0001-ceph-check-i_nlink-while-converting-a-file-handle-to.patch View (1.21 KB) Luis Henriques, 05/17/2017 11:13 AM

History

#2 Updated by Zheng Yan about 5 years ago

  • Status changed from 7 to Resolved

Also available in: Atom PDF