Project

General

Profile

Actions

Bug #19941

closed

ceph-disk fails if OSD udev rule triggers prior to mount of /var

Added by David Disseldorp almost 7 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
Urgent
Category:
-
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
kraken,jewel
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
ceph-disk
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Another "my OSDs don't come up on reboot" bug:

ceph-disk unconditionally calls setup_statedir() during initialisation, which manipulates /var/lib/ceph/tmp :

def setup_statedir(dir):
    # XXX The following use of globals makes linting
    # really hard. Global state in Python is iffy and
    # should be avoided.
    global STATEDIR
    STATEDIR = dir

    if not os.path.exists(STATEDIR):
        os.mkdir(STATEDIR)
    if not os.path.exists(STATEDIR + "/tmp"):
        os.mkdir(STATEDIR + "/tmp")

    global prepare_lock
    prepare_lock = FileLock(STATEDIR + '/tmp/ceph-disk.prepare.lock')

    global activate_lock
    activate_lock = FileLock(STATEDIR + '/tmp/ceph-disk.activate.lock')
...


This may fail for users with a separately mounted /var filesystem, where /var hasn't been mounted prior to 95-ceph-osd.rules being triggered.

Related issues 2 (0 open2 closed)

Copied to Ceph - Backport #20150: kraken: ceph-disk fails if OSD udev rule triggers prior to mount of /varResolvedNathan CutlerActions
Copied to Ceph - Backport #20151: jewel: ceph-disk fails if OSD udev rule triggers prior to mount of /varResolvedWei-Chung ChengActions
Actions #2

Updated by Loïc Dachary almost 7 years ago

  • Description updated (diff)
Actions #3

Updated by Loïc Dachary almost 7 years ago

  • Status changed from New to 12
  • Priority changed from Normal to Urgent
Actions #5

Updated by Loïc Dachary almost 7 years ago

  • Backport set to kraken,jewel
Actions #6

Updated by Loïc Dachary almost 7 years ago

  • Status changed from 12 to Pending Backport
Actions #7

Updated by Nathan Cutler almost 7 years ago

  • Copied to Backport #20150: kraken: ceph-disk fails if OSD udev rule triggers prior to mount of /var added
Actions #8

Updated by Nathan Cutler almost 7 years ago

  • Copied to Backport #20151: jewel: ceph-disk fails if OSD udev rule triggers prior to mount of /var added
Actions #9

Updated by Nathan Cutler almost 7 years ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF