Bug #1946: snapshot inherits timestamp/size/etc from modified trunk dir upon mds restart - CephFS - Ceph

Actions

Copy link

Bug #1946

closed

snapshot inherits timestamp/size/etc from modified trunk dir upon mds restart

Added by Alexandre Oliva over 12 years ago. Updated about 11 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Sage Weil

Category:

Target version:

% Done:

Source:

Tags:

Backport:

Regression:

Severity:

Reviewed:

Affected Versions:

ceph-qa-suite:

Component(FS):

Labels (FS):

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

mkdir .snap/name
ls -ld . .snap/name

both have the same timestamp
touch .
ls -ld . .snap/name
now . has a different timestamp from the snapshot

Now unmount the filesystem, restart the mds, re-mount it and enter the directory again

ls -ld . .snap/name

now both have the same timestamp again, and it's the newer timestamp

Actions

Copy link

Updated by Sage Weil over 12 years ago

It looks to me like the problem is that CInode::old_inodes isn't included in EMetaBlob::fullbit. CInode::pick_old_inode() then picks the head for everything and the directory appears to have the wrong stat values.

The fix will include:
- adding old_inodes to fullbit. version the encoding appropriately.
- probably some changes to EMetaBlob::add_primary_dentry and add_root() to fill it in
- a new feature bit in the CompatSet?

Actions

Copy link