https://tracker.ceph.com/https://tracker.ceph.com/favicon.ico2012-01-13T09:50:24ZCeph Ceph - Bug #1935: teuthology: readwrite/roundtrip jobs run manually, but not in suitehttps://tracker.ceph.com/issues/1935?journal_id=81482012-01-13T09:50:24ZAnonymous
<ul></ul><p>s3tests/functional (run via nosetests) reads a .ini -style configuration.</p>
<p>This was not flexible enough for all the needs the benchmarks (readwrite, roundtrip) had, so we switched those to a yaml config format. There's a sample in config.yaml.SAMPLE.</p>
<p>At some point, s3tests/functional should be ported to read the newer, more flexible format also. This wasn't seen as critical enough to warrant work at the time, but clearly it would help with the confusion.</p> Ceph - Bug #1935: teuthology: readwrite/roundtrip jobs run manually, but not in suitehttps://tracker.ceph.com/issues/1935?journal_id=81492012-01-13T09:58:22ZAnonymous
<ul></ul><p>More specific plan for change:</p>
<p>- change s3tests/functional/__init__.py to read env var S3TEST_YAML, raise if it is not there (explicit error to prompt users to migrate)<br />- make it read the configuration via s3tests/common.py read_config(), etc; share more code between them</p>
<p>- there seems to be a lot of copy-paste code between s3tests/common.py and s3tests/functional/__init__.py, clean up:<br /> - s3tests/common.py setup() seems only used by s3tests/fuzz (and the debug runner in s3tests/generate_objects.py), refactor for clarity so it's not confused with s3tests/functional/__init__.py setup()<br /> - choose_bucket_prefix<br /> - nuke_prefixed_buckets<br /> - get_new_bucket</p> Ceph - Bug #1935: teuthology: readwrite/roundtrip jobs run manually, but not in suitehttps://tracker.ceph.com/issues/1935?journal_id=81502012-01-13T10:04:39ZAnonymous
<ul></ul><p>I'm wrong, ignore me for a while.</p> Ceph - Bug #1935: teuthology: readwrite/roundtrip jobs run manually, but not in suitehttps://tracker.ceph.com/issues/1935?journal_id=81512012-01-13T10:13:04ZSage Weilsage@newdream.net
<ul><li><strong>Assignee</strong> set to <i>Anonymous</i></li></ul> Ceph - Bug #1935: teuthology: readwrite/roundtrip jobs run manually, but not in suitehttps://tracker.ceph.com/issues/1935?journal_id=81552012-01-13T11:31:51ZAnonymous
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li></ul><p>Alright, I was reading the wrong file. s3readwrite.py and s3roundtrip.py do use the yaml format. The above cleanups would still be valid.</p>
<p>Bug found & squished (still needs to be deployed on teuthworker I think):</p>
<p>commit 3bfa41cf6ad945c21cf8499f94dd71cf07b3cb04<br />Author: Tommi Virtanen <<a class="email" href="mailto:tommi.virtanen@dreamhost.com">tommi.virtanen@dreamhost.com</a>><br />Date: 2012-01-13 11:26:36 -0800</p>
<pre><code>Use yaml.safe_dump so unicode doesn't mess up the yaml files.</code></pre>
<pre><code>In general, yaml.dump is comparable to pickle, and my personal<br /> coding standard says <strong>never</strong> use it. yaml.safe_dump is much nicer.<br /> yaml.dump should have been named yaml.unsafe_dump, yaml.safe_dump<br /> should have been named yaml.dump :(</code></pre> Ceph - Bug #1935: teuthology: readwrite/roundtrip jobs run manually, but not in suitehttps://tracker.ceph.com/issues/1935?journal_id=81562012-01-13T11:40:40ZJosh Durgin
<ul></ul><p>teuthworker is updated.</p>