Project

General

Profile

Cleanup #1899

use acx_pthread instead of hardcoding libs and cflags into build system

Added by Anonymous almost 12 years ago. Updated almost 12 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
% Done:

0%

Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

Hardcoding -lphtread is not the most portable way of including threads support. Please use upstream macros instead.
First patch includes m4 macro, second makes use of it

0001-Add-recent-acx_pthread.m4-that-has-a-fix-for-nostdli.patch View (15.1 KB) Anonymous, 01/07/2012 07:18 AM

0002-Use-ACX_PTHREAD-in-configure.ac-and-resulting-flags-.patch View (14.9 KB) Anonymous, 01/07/2012 07:18 AM

Related issues

Related to Ceph - Bug #1797: configure doesn't link to pthread on Fedora 14 on linking librados-config Resolved 12/07/2011

History

#1 Updated by Sage Weil almost 12 years ago

Looks good.. can I add your Signed-off-by to this?

#2 Updated by Anonymous almost 12 years ago

Sage Weil wrote:

Looks good.. can I add your Signed-off-by to this?

Sure

#3 Updated by Sage Weil almost 12 years ago

  • Status changed from New to Resolved

applied this a while back, c5144eed4eadf5cfaa0a41c0ced2a1cd3462289f

Also available in: Atom PDF