https://tracker.ceph.com/https://tracker.ceph.com/favicon.ico2017-02-04T03:38:50ZCeph Ceph - Backport #18814: kraken: PrimaryLogPG: up_osd_features used without the requires_kraken flag in krakenhttps://tracker.ceph.com/issues/18814?journal_id=856322017-02-04T03:38:50ZNathan Cutlerncutler@suse.cz
<ul><li><strong>Copied from</strong> <i><a class="issue tracker-1 status-3 priority-6 priority-high2 closed" href="/issues/18644">Bug #18644</a>: PrimaryLogPG: up_osd_features used without the requires_kraken flag in kraken</i> added</li></ul> Ceph - Backport #18814: kraken: PrimaryLogPG: up_osd_features used without the requires_kraken flag in krakenhttps://tracker.ceph.com/issues/18814?journal_id=857032017-02-06T15:45:32ZShinobu Kinjoshinobu@redhat.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/85703/diff?detail_id=82804">diff</a>)</li><li><strong>Assignee</strong> set to <i>Shinobu Kinjo</i></li></ul> Ceph - Backport #18814: kraken: PrimaryLogPG: up_osd_features used without the requires_kraken flag in krakenhttps://tracker.ceph.com/issues/18814?journal_id=857362017-02-07T00:01:10ZShinobu Kinjoshinobu@redhat.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Ceph - Backport #18814: kraken: PrimaryLogPG: up_osd_features used without the requires_kraken flag in krakenhttps://tracker.ceph.com/issues/18814?journal_id=858062017-02-08T17:55:09ZLoïc Dacharyloic@dachary.org
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/85806/diff?detail_id=82891">diff</a>)</li><li><strong>Status</strong> changed from <i>In Progress</i> to <i>New</i></li></ul><p>master pull request: <a class="external" href="https://github.com/ceph/ceph/pull/13114">https://github.com/ceph/ceph/pull/13114</a></p>
<p>Please set the to "In Progress" when a backport pull request is ready</p> Ceph - Backport #18814: kraken: PrimaryLogPG: up_osd_features used without the requires_kraken flag in krakenhttps://tracker.ceph.com/issues/18814?journal_id=858162017-02-08T23:07:23ZShinobu Kinjoshinobu@redhat.com
<ul></ul><p>@Loic Sorry for the late. The reason why I just waited is that there are 2 commits for the bug:</p>
<p><a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: gpf in tcp_sendpage (Closed)" href="https://tracker.ceph.com/issues/1">#1</a> <a class="external" href="https://github.com/ceph/ceph/pull/13114/commits/1a5cc32f0a3bf5ef06642402e930e3786700ab7d">https://github.com/ceph/ceph/pull/13114/commits/1a5cc32f0a3bf5ef06642402e930e3786700ab7d</a></p>
<p><a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: BUG at fs/ceph/caps.c:2178 (Closed)" href="https://tracker.ceph.com/issues/2">#2</a> <a class="external" href="https://github.com/ceph/ceph/pull/13114/commits/47066ef310e2dea3501657851bf3c2b96efb0669">https://github.com/ceph/ceph/pull/13114/commits/47066ef310e2dea3501657851bf3c2b96efb0669</a></p>
<p>When I tried to cherry-pick, results for both ended up with:</p>
<p>[root@octopus ceph]# git cherry-pick -x 1a5cc32f0a3bf5ef06642402e930e3786700ab7d<br />fatal: bad object 1a5cc32f0a3bf5ef06642402e930e3786700ab7d</p>
<p>[root@octopus ceph]# git cherry-pick -x 47066ef310e2dea3501657851bf3c2b96efb0669<br />fatal: bad object 47066ef310e2dea3501657851bf3c2b96efb0669</p>
<p>There should be missing something. Please advice :)</p> Ceph - Backport #18814: kraken: PrimaryLogPG: up_osd_features used without the requires_kraken flag in krakenhttps://tracker.ceph.com/issues/18814?journal_id=858172017-02-08T23:09:27ZShinobu Kinjoshinobu@redhat.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Need More Info</i></li></ul> Ceph - Backport #18814: kraken: PrimaryLogPG: up_osd_features used without the requires_kraken flag in krakenhttps://tracker.ceph.com/issues/18814?journal_id=858212017-02-09T00:25:08ZShinobu Kinjoshinobu@redhat.com
<ul><li><strong>Status</strong> changed from <i>Need More Info</i> to <i>New</i></li></ul><p>Yay git did some trick =)</p> Ceph - Backport #18814: kraken: PrimaryLogPG: up_osd_features used without the requires_kraken flag in krakenhttps://tracker.ceph.com/issues/18814?journal_id=858252017-02-09T01:27:13ZShinobu Kinjoshinobu@redhat.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Need More Info</i></li></ul><p>1st one is fine but 2nd one:</p>
<p>[root@octopus ceph]# git cherry-pick <del>x 1a5cc32f0a3bf5ef06642402e930e3786700ab7d<br />[wip-18751-hammer fcff3dc] osd/OSDMap: reflect REQUIRE_*_OSDS flag in required features<br /> Author: Sage Weil <<a class="email" href="mailto:sage@redhat.com">sage@redhat.com</a>><br /> 1 file changed, 15 insertions(+), 2 deletions(</del>)</p>
<p>[root@octopus ceph]# git cherry-pick -x 47066ef310e2dea3501657851bf3c2b96efb0669<br />error: could not apply 47066ef... osd/PrimaryLogPG: encode object_info with required (not up) features<br />hint: after resolving the conflicts, mark the corrected paths<br />hint: with 'git add <paths>' or 'git rm <paths>'<br />hint: and commit the result with 'git commit'</p> Ceph - Backport #18814: kraken: PrimaryLogPG: up_osd_features used without the requires_kraken flag in krakenhttps://tracker.ceph.com/issues/18814?journal_id=858772017-02-09T19:10:14ZNathan Cutlerncutler@suse.cz
<ul></ul><p>@Shinobu The idea is to resolve the conflicts, if you can, and describe how you did it in the commit message. This can sometimes be a little tricky. There is some documentation on backporting commits here: <a class="external" href="http://tracker.ceph.com/projects/ceph-releases/wiki/HOWTO_backport_commits">http://tracker.ceph.com/projects/ceph-releases/wiki/HOWTO_backport_commits</a></p> Ceph - Backport #18814: kraken: PrimaryLogPG: up_osd_features used without the requires_kraken flag in krakenhttps://tracker.ceph.com/issues/18814?journal_id=859032017-02-10T09:59:53ZShinobu Kinjoshinobu@redhat.com
<ul></ul><p>@Nathan Thank you so much for your help. Please let me give it try again and I will write some up here.</p> Ceph - Backport #18814: kraken: PrimaryLogPG: up_osd_features used without the requires_kraken flag in krakenhttps://tracker.ceph.com/issues/18814?journal_id=859352017-02-11T22:57:53ZShinobu Kinjoshinobu@redhat.com
<ul><li><strong>Status</strong> changed from <i>Need More Info</i> to <i>New</i></li></ul> Ceph - Backport #18814: kraken: PrimaryLogPG: up_osd_features used without the requires_kraken flag in krakenhttps://tracker.ceph.com/issues/18814?journal_id=859372017-02-12T00:11:11ZShinobu Kinjoshinobu@redhat.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul><p>@Nathan Yay finally. Hopefully there is nothing stupid :3</p>
<p><del><a class="external" href="https://github.com/ceph/ceph/pull/13373">https://github.com/ceph/ceph/pull/13373</a></del></p> Ceph - Backport #18814: kraken: PrimaryLogPG: up_osd_features used without the requires_kraken flag in krakenhttps://tracker.ceph.com/issues/18814?journal_id=859442017-02-12T08:27:38ZShinobu Kinjoshinobu@redhat.com
<ul></ul><p>@Nathan I delete remote branch which was used for PR#13373 because the PR was something definitely wrong and messy because of lack of my knowledge regarding to Git.</p>
<p>I've been getting better understanding how Git works. I will create a new PR.</p>
<p>This backport has been really really good exercise to me :)</p> Ceph - Backport #18814: kraken: PrimaryLogPG: up_osd_features used without the requires_kraken flag in krakenhttps://tracker.ceph.com/issues/18814?journal_id=859452017-02-12T08:28:00ZShinobu Kinjoshinobu@redhat.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>New</i></li></ul> Ceph - Backport #18814: kraken: PrimaryLogPG: up_osd_features used without the requires_kraken flag in krakenhttps://tracker.ceph.com/issues/18814?journal_id=859472017-02-12T11:03:21ZNathan Cutlerncutler@suse.cz
<ul></ul><p>@Shinobu Backporting is an excellent way to practice with git :-) HINT: read about "interactive rebasing" - if you make a mistake in a PR, you don't have to close it and open another one. You can rebase your wip branch and then force-push it (git push <del>f origin wip</del>...) and the PR will be automatically updated.</p> Ceph - Backport #18814: kraken: PrimaryLogPG: up_osd_features used without the requires_kraken flag in krakenhttps://tracker.ceph.com/issues/18814?journal_id=862302017-02-17T16:45:33ZShinobu Kinjoshinobu@redhat.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/86230/diff?detail_id=83250">diff</a>)</li><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Ceph - Backport #18814: kraken: PrimaryLogPG: up_osd_features used without the requires_kraken flag in krakenhttps://tracker.ceph.com/issues/18814?journal_id=901792017-04-22T08:53:39ZNathan Cutlerncutler@suse.cz
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li><li><strong>Target version</strong> set to <i>v11.2.1</i></li></ul>