Project

General

Profile

Bug #18521

rocksdb repository misses references: stable hammer releases fail to build

Added by Loïc Dachary about 7 years ago. Updated 11 months ago.

Status:
Closed
Priority:
Urgent
Assignee:
-
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Crash signature (v1):
Crash signature (v2):

Description

At some point in the recent past, some references of the https://github.com/ceph/rocksdb/ mirror were removed, or branches were rebased. For instance:

https://github.com/ceph/rocksdb/commit/422e26633267b25c225975b456a9f4fc40091a2e

became an isolated commit. This has the infortunate side effect that it is not cloned, nor is it downloadable (github restriction). This commit is however necessary to compile v0.94.9 because the rocksdb submodule points to it.

In order to fix this, it is enough to find a repository cloned before this problem happened and create a reference on this commit. For instance:

https://github.com/ceph/rocksdb/tree/precious-v0.94.9

This allows building successfully https://jenkins.ceph.com/job/ceph-dev-new-setup/544/console

History

#1 Updated by Loïc Dachary about 7 years ago

FYI kefu pushed https://github.com/ceph/rocksdb/tree/hammer which is likely to restore a number of commits.

#2 Updated by Nathan Cutler about 7 years ago

Also happening in master (?):

Unable to checkout '3d899da2f005f72e1682f0e000aa41b82dbd2fde' in submodule path 'src/rocksdb'

#3 Updated by Loïc Dachary about 7 years ago

See the Shaman build fails with "reference is not a tree" thread on ceph-devel for more.

#4 Updated by Kefu Chai about 7 years ago

Loïc, my bad. i just recalled that i deleted the branch of "wip-rocksdb" on ceph/rocksdb yesterday. i thought it was but a "wip" branch. maybe we should be careful when merging a submodule update commit next time, to make sure the picked submodule change is not in a wip branch.

#5 Updated by Nathan Cutler about 7 years ago

As Kefu pointed out in the mailing list, 3d899da2f005f72e1682f0e000aa41b82dbd2fde is not in master, but rather in a PR that is still open. But it's currently impossible to test that PR because 3d899da2f005f72e1682f0e000aa41b82dbd2fde is "not a tree" (not possible to checkout).

#6 Updated by Patrick Donnelly over 4 years ago

  • Status changed from 12 to New

#7 Updated by Laura Flores 11 months ago

  • Status changed from New to Closed

This doesn't seem relevant anymore.

Also available in: Atom PDF