Bug #18420: Wrong interaction of os_version provided on command line with os_type test definition (affects --distro and --distro-version, too) - teuthology - Ceph

Actions

Copy link

Bug #18420

open

Wrong interaction of os_version provided on command line with os_type test definition (affects --distro and --distro-version, too)

Added by Nathan Cutler over 7 years ago. Updated over 4 years ago.

Status:

New

Priority:

Normal

Assignee:

Category:

% Done:

Source:

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Crash signature (v1):

Crash signature (v2):

Description

Situation: test definition contains "os_type: centos" but does not contain "os_version". On the "teuthology-suite" command line, I give a yaml file containing:

os_type: ubuntu
os_version: "14.04"

This results in a test definition containing:

os_type: centos
os_version: "14.04"

Since there is no centos 14.04, the job fails.

Related issues 1 (1 open — 0 closed)

Actions

Copy link

Updated by Vasu Kulkarni over 7 years ago

you should use --distro and --distro-version for those values, since the sha it gets will be inaccurate when using yaml overrides.

Actions

Copy link

Updated by Nathan Cutler over 7 years ago

Thanks, I'll try that.

Actions

Copy link

Updated by Nathan Cutler over 7 years ago

Subject changed from Wrong interaction of os_version provided on command line with os_type test definition to Wrong interaction of os_version provided on command line with os_type test definition (affects --distro and --distro-version, too)
Status changed from New to 12

Trying with --distro ubuntu and --distro-version trusty, but that appears to have the same problem:

$ teuthology-suite --priority 101 --suite rados --subset $(expr $RANDOM % 2000)/2000 --email ncutler@suse.cz --ceph wip-hammer-backports --machine-type smithi -k distro --distro ubuntu --distro-version trusty --dry-run
...
2017-01-13 18:33:53,369.369 INFO:teuthology.suite.run:Suite rados in /home/smithfarm/src/git.ceph.com_ceph-c_wip-hammer-backports/qa/suites/rados generated 112 jobs (not yet filtered)
Traceback (most recent call last):
  File "./virtualenv/bin/teuthology-suite", line 11, in <module>
    load_entry_point('teuthology', 'console_scripts', 'teuthology-suite')()
  File "/home/smithfarm/teuthology/scripts/suite.py", line 138, in main
    return teuthology.suite.main(args)
  File "/home/smithfarm/teuthology/teuthology/suite/__init__.py", line 88, in main
    run.prepare_and_schedule()
  File "/home/smithfarm/teuthology/teuthology/suite/run.py", line 309, in prepare_and_schedule
    num_jobs = self.schedule_suite()
  File "/home/smithfarm/teuthology/teuthology/suite/run.py", line 498, in schedule_suite
    self.collect_jobs(arch, configs, self.args.newest)
  File "/home/smithfarm/teuthology/teuthology/suite/run.py", line 412, in collect_jobs
    self.package_versions
  File "/home/smithfarm/teuthology/teuthology/suite/util.py", line 378, in get_package_versions
    distro_version=os_version,
  File "/home/smithfarm/teuthology/teuthology/suite/util.py", line 266, in package_version_for_hash
    sha1=hash,
  File "/home/smithfarm/teuthology/teuthology/packaging.py", line 841, in __init__
    super(ShamanProject, self).__init__(project, job_config, ctx, remote)
  File "/home/smithfarm/teuthology/teuthology/packaging.py", line 456, in __init__
    self._init_from_config()
  File "/home/smithfarm/teuthology/teuthology/packaging.py", line 491, in _init_from_config
    OS.version_codename(self.os_type, self.os_version)
  File "/home/smithfarm/teuthology/teuthology/orchestra/opsys.py", line 192, in version_codename
    (version_or_codename, name))
KeyError: '14.04 not a centos version or codename'

Actions

Copy link