Project

General

Profile

Actions

Bug #18297

closed

ceph cli fails on monitors that don't send 'flags' in command descs

Added by Dan Mick over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
ceph cli
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
Yes
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

61d63433dfdcc08ecc21ba4f645794da5e01823c added the ability to mark commands with flags to say they are obsolete or deprecated, and avoid showing them in help. The code unconditionally looks for the 'flags' key on the command dict, which will not be present when run against older mons.

Validate presence of the key before checking it.


Related issues 1 (0 open1 closed)

Copied to Ceph - Backport #18318: jewel: ceph cli fails on monitors that don't send 'flags' in command descsRejectedActions
Actions #1

Updated by Sage Weil over 7 years ago

  • Status changed from Fix Under Review to Pending Backport
  • Backport set to jewel
Actions #3

Updated by Dan Mick over 7 years ago

  • Priority changed from High to Urgent
Actions #4

Updated by Dan Mick over 7 years ago

  • Priority changed from Urgent to High
Actions #5

Updated by Nathan Cutler over 7 years ago

  • Copied to Backport #18318: jewel: ceph cli fails on monitors that don't send 'flags' in command descs added
Actions #6

Updated by Nathan Cutler over 7 years ago

@Dan: Are you sure this fix is applicable to jewel? The flags appear to have been introduced by https://github.com/ceph/ceph/commit/61d63433

Actions #7

Updated by Dan Mick over 7 years ago

No; Sage added that backport note, I haven't checked.

Actions #8

Updated by Nathan Cutler over 7 years ago

  • Status changed from Pending Backport to Resolved
Actions #9

Updated by Nathan Cutler over 7 years ago

  • Backport deleted (jewel)
Actions

Also available in: Atom PDF