Project

General

Profile

Actions
Copy link

Feature #18206

closed

osd: osd_scrub_during_recovery only considers primary, not replicas

Added by Sage Weil over 7 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
David Zafman
Category:
Scrub/Repair
Target version:
-
% Done:

0%

Source:
Tags:
Backport:
jewel, luminous
Reviewed:
Affected Versions:
Component(RADOS):
OSD
Pull request ID:

Description

We should also avoid scrubbing if the replica is busy doing recovery. That means the scrub scheduler should decline the reservation, probably, but we need to verify that some timed backoff is in place.

Related issues 2 (0 open — 2 closed)

Copied to RADOS - Backport #21077: luminous: osd: osd_scrub_during_recovery only considers primary, not replicasResolvedAbhishek LekshmananActions
Copied to RADOS - Backport #21117: jewel: osd: osd_scrub_during_recovery only considers primary, not replicasResolvedDavid ZafmanActions
Actions
Copy link
 #1

Updated by Greg Farnum almost 7 years ago

  • Tracker changed from Bug to Feature
  • Project changed from Ceph to RADOS
  • Category set to Scrub/Repair
  • Component(RADOS) OSD added
Actions
Copy link
 #2

Updated by David Zafman over 6 years ago

  • Status changed from 12 to In Progress
  • Assignee set to David Zafman
Actions
Copy link
 #3

Updated by David Zafman over 6 years ago

  • Backport set to jewel, luminous
Actions
Copy link
 #4

Updated by Kefu Chai over 6 years ago

david, i just read your inquiry over IRC. what would you want me to review for this ticket? do we have a PR for it already?

Actions
Copy link
 #5

Updated by David Zafman over 6 years ago

  • Status changed from In Progress to Fix Under Review
Actions
Copy link
 #7

Updated by Kefu Chai over 6 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions
Copy link
 #8

Updated by Abhishek Lekshmanan over 6 years ago

  • Copied to Backport #21077: luminous: osd: osd_scrub_during_recovery only considers primary, not replicas added
Actions
Copy link
 #9

Updated by Vikhyat Umrao over 6 years ago

  • Backport changed from jewel, luminous to jewel
Actions
Copy link
 #10

Updated by Nathan Cutler over 6 years ago

Verified that both commits from https://github.com/ceph/ceph/pull/17039 were cherry-picked to luminous.

Actions
Copy link
 #11

Updated by Vikhyat Umrao over 6 years ago

Thanks Nathan. I think some issue and it did not create a tracker for jewel backport so I removed luminous so it can create for jewel.

Actions
Copy link
 #12

Updated by Nathan Cutler over 6 years ago

  • Backport changed from jewel to jewel, luminous

@Vikhyat Umrao, I think Abhi just created the luminous backport tracker manually. The jewel one will be created automagically when I next run the script.

Actions
Copy link
 #13

Updated by Nathan Cutler over 6 years ago

  • Copied to Backport #21117: jewel: osd: osd_scrub_during_recovery only considers primary, not replicas added
Actions
Copy link
 #14

Updated by Vikhyat Umrao over 6 years ago

Nathan Cutler wrote:

@Vikhyat Umrao, I think Abhi just created the luminous backport tracker manually. The jewel one will be created automagically when I next run the script.

Thanks Nathan.

Actions
Copy link
 #15

Updated by Nathan Cutler over 6 years ago

  • Status changed from Pending Backport to Resolved
Actions
Copy link

Also available in: Atom PDF