Bug #17898: tests: flake8 3.1.1 behavior changed - Ceph - Ceph

Actions

Copy link

Bug #17898

closed

tests: flake8 3.1.1 behavior changed

Added by Loïc Dachary over 7 years ago. Updated about 7 years ago.

Status:

Resolved

Priority:

Urgent

Assignee:

Loïc Dachary

Category:

Target version:

% Done:

Source:

Tags:

Backport:

jewel

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

flake8 3.1.1 published a few hours ago does not behave the same and fails with:

flake8 runtests: commands[0] | flake8 --ignore=H105,H405,E127 ceph_disk tests
ceph_disk/main.py:173:1: E305 expected 2 blank lines after class or function definition, found 1
ceph_disk/main.py:5011:1: E305 expected 2 blank lines after class or function definition, found 1

on jewel and probably on master as well.

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Loïc Dachary over 7 years ago

Backport set to jewel,hammer

Actions

Copy link

Updated by Ken Dreyer over 7 years ago

another approach, adding the whitespace in https://github.com/ceph/ceph/pull/11973

Actions

Copy link

Updated by Loïc Dachary over 7 years ago

Status changed from 12 to Pending Backport
Backport changed from jewel,hammer to jewel

Actions

Copy link

Updated by Loïc Dachary over 7 years ago

Copied to Backport #17903: jewel: tests: flake8 3.1.1 behavior changed added

Actions

Copy link

Updated by Ken Dreyer over 7 years ago

Discussed with Loic in IRC. We can revert the flake8 version pinning here, and re-address if further flake8 errors are found (with a couple other options).

Actions

Copy link