Project

General

Profile

Bug #1767

osd_client: send_request() cannot fail

Added by Anonymous almost 8 years ago. Updated almost 8 years ago.

Status:
Resolved
Priority:
Low
Assignee:
-
Category:
-
Target version:
Start date:
11/30/2011
Due date:
% Done:

0%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Crash signature:

Description

The static __send_request() routine is sure to succeed in queuing its request for the specified osd client, yet ceph_osdc_start_request() checks for such a failure and either logs an error or unregisters the request. Another call to __send_request() from send_queued does not check for an error.

The right thing to do is probably to change __send_request() to return void and clean up the call in ceph_osdc_start_request()

History

#1 Updated by Sage Weil almost 8 years ago

  • Project changed from Ceph to Linux kernel client
  • Category deleted (OSD)

#2 Updated by Sage Weil almost 8 years ago

  • translation missing: en.field_position set to 2

#3 Updated by Sage Weil almost 8 years ago

  • Status changed from New to Resolved
  • Target version set to v3.3

commit:24e08cacc999503a069003364565116c923342b9

Also available in: Atom PDF