Project

General

Profile

Bug #17622

Building Ceph v10.2.3 with "make" may kill the compiling system

Added by Roy Keene over 7 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
build
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Ceph v10.2.3 src/Makefile calls the rocksdb static_lib target with "make -j$(shell nproc)". If the "nproc" command does not exist, this becomes "make -j" which quickly overwhelms most systems into a state where they will never recover.

Attempting to override the user's preferences for parallel build is a bad idea, especially when it is done poorly.

Attached is a patch that removes this.

ceph-10.2.3-dontoverloadwhenrunningmakewithoutnproc.diff View - Unified diff against Ceph v10.2.3 (2.64 KB) Roy Keene, 10/19/2016 05:59 PM

History

#1 Updated by Samuel Just over 7 years ago

  • Priority changed from High to Normal

#2 Updated by Sage Weil almost 3 years ago

  • Status changed from New to Closed

#3 Updated by Roy Keene almost 3 years ago

Was this resolved ?

#4 Updated by Sebastian Wagner almost 3 years ago

The project switched over to cmake.

Also available in: Atom PDF