Project

General

Profile

Bug #17250

arch flags not defined for armv8 crc

Added by Dan Mick almost 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
build
Target version:
-
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature:

Description

cmake/modules/SIMDExt.cmake tests and sets SIMD extension -march flags for the floating point compilations, but src/CMakeLists.txt needs to have the CRC flags defined in ARM_CRC_FLAGS.

History

#1 Updated by Dan Mick almost 4 years ago

This makes it work:

--- a/cmake/modules/SIMDExt.cmake
+++ b/cmake/modules/SIMDExt.cmake
@@ -17,7 +17,7 @@
 if(CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64|AARCH64")
   CHECK_C_COMPILER_FLAG(-march=armv8-a+crc HAVE_ARMV8_CRC)
   if(HAVE_ARMV8_CRC)
-    set(ARM_NEON_FLAGS "-march=armv8-a+crc -DARCH_AARCH64")
+    set(ARM_CRC_FLAGS "-march=armv8-a+crc -DARCH_AARCH64")
   endif()
   CHECK_C_COMPILER_FLAG(-march=armv8-a+simd HAVE_NEON)
   if(HAVE_NEON)

#2 Updated by Kefu Chai almost 4 years ago

  • Status changed from In Progress to Fix Under Review

#3 Updated by Kefu Chai almost 4 years ago

  • Status changed from Fix Under Review to Resolved

Also available in: Atom PDF