Bug #17250: arch flags not defined for armv8 crc - Ceph - Ceph

Actions

Copy link

Bug #17250

closed

arch flags not defined for armv8 crc

Added by Dan Mick over 7 years ago. Updated over 7 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Dan Mick

Category:

build

Target version:

% Done:

Source:

Development

Tags:

Backport:

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

ceph-qa-suite:

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

cmake/modules/SIMDExt.cmake tests and sets SIMD extension -march flags for the floating point compilations, but src/CMakeLists.txt needs to have the CRC flags defined in ARM_CRC_FLAGS.

Actions

Copy link

Updated by Dan Mick over 7 years ago

This makes it work:

--- a/cmake/modules/SIMDExt.cmake
+++ b/cmake/modules/SIMDExt.cmake
@@ -17,7 +17,7 @@
 if(CMAKE_SYSTEM_PROCESSOR MATCHES "aarch64|AARCH64")
   CHECK_C_COMPILER_FLAG(-march=armv8-a+crc HAVE_ARMV8_CRC)
   if(HAVE_ARMV8_CRC)
-    set(ARM_NEON_FLAGS "-march=armv8-a+crc -DARCH_AARCH64")
+    set(ARM_CRC_FLAGS "-march=armv8-a+crc -DARCH_AARCH64")
   endif()
   CHECK_C_COMPILER_FLAG(-march=armv8-a+simd HAVE_NEON)
   if(HAVE_NEON)

Actions

Copy link