Project

General

Profile

Actions

Bug #16838

closed

Regression when using teuthology-suite with --kernel

Added by Zack Cerza over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Immediate
Assignee:
Category:
-
% Done:

0%

Source:
other
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Crash signature (v1):
Crash signature (v2):

Description

The call signature of get_gitbuilder_hash changed here:
https://github.com/ceph/teuthology/commit/8e71e4099d12608bc07a5e35081f5290420ea9ba#diff-b6c20d8e0e947feb7031f8a7a7382af2R87

But its caller was not updated:
https://github.com/ceph/teuthology/blob/8e71e4099d12608bc07a5e35081f5290420ea9ba/teuthology/suite/run.py#L112-L114

This caused any teuthology-suite call using --kernel to fail:

teuthology-suite -v -c master -m smithi -s krbd -k testing --dry-run                                            2 ↵
2016-07-27 12:33:40,437.437 DEBUG:teuthology.suite.util:Defaults for machine_type smithi distro centos: arch=x86_64, release=centos7, pkg_type=rpm
Traceback (most recent call last):
  File "/Users/zack/inkdev/teuthology/virtualenv/bin/teuthology-suite", line 9, in <module>
    load_entry_point('teuthology', 'console_scripts', 'teuthology-suite')()
  File "/Users/zack/inkdev/teuthology/scripts/suite.py", line 107, in main
    return teuthology.suite.main(args)
  File "/Users/zack/inkdev/teuthology/teuthology/suite/__init__.py", line 64, in main
    run = Run(conf)
  File "/Users/zack/inkdev/teuthology/teuthology/suite/run.py", line 39, in __init__
    self.base_config = self.create_initial_config()
  File "/Users/zack/inkdev/teuthology/teuthology/suite/run.py", line 81, in create_initial_config
    self.kernel_dict = self.choose_kernel()
  File "/Users/zack/inkdev/teuthology/teuthology/suite/run.py", line 118, in choose_kernel
    self.args.machine_type, self.args.distro,
  File "/Users/zack/inkdev/teuthology/teuthology/suite/util.py", line 112, in get_gitbuilder_hash
    arch=arch,
  File "/Users/zack/inkdev/teuthology/teuthology/packaging.py", line 446, in __init__
    self._init_from_config()
  File "/Users/zack/inkdev/teuthology/teuthology/packaging.py", line 479, in _init_from_config
    OS.version_codename(self.os_type, self.os_version)
  File "/Users/zack/inkdev/teuthology/teuthology/orchestra/opsys.py", line 188, in version_codename
    (version_or_codename, name))
KeyError: '14.04 not a centos version or codename'
Actions #1

Updated by Zack Cerza over 7 years ago

  • Subject changed from Regression to Regression when using teuthology-suite with --kernel
Actions #2

Updated by Zack Cerza over 7 years ago

  • Status changed from In Progress to Fix Under Review
Actions #3

Updated by Zack Cerza over 7 years ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF