Bug #16709: No output for "ceph mds rmfailed 0 --yes-i-really-mean-it" command - CephFS - Ceph

Actions

Copy link

Bug #16709

closed

No output for "ceph mds rmfailed 0 --yes-i-really-mean-it" command

Added by Rohith Radhakrishnan almost 8 years ago. Updated over 6 years ago.

Status:

Resolved

Priority:

High

Assignee:

Category:

Administration/Usability

Target version:

% Done:

Source:

other

Tags:

Backport:

jewel, kraken

Regression:

Severity:

3 - minor

Reviewed:

Affected Versions:

Ceph - v10.2.2

ceph-qa-suite:

Component(FS):

Labels (FS):

Pull request ID:

Crash signature (v1):

Crash signature (v2):

Description

there is no output for the command ceph mds rmfailed 0 --yes-i-really-mean-it. The command is successful how many ever times we run it. There is nothing displayed to actually show if the command is successful or not or whether the mds has actually been failed.

ceph mds rmfailed 0 --yes-i-really-mean-it
ems@rack2-client-3:~$ ceph mds rmfailed 1 --yes-i-really-mean-it
Error EINVAL: Rank '1' not foundinvalid role '1'
ems@rack2-client-3:~$ ceph mds rmfailed 0 --yes-i-really-mean-it
ems@rack2-client-3:~$ ceph mds rmfailed 0 --yes-i-really-mean-it
ems@rack2-client-3:~$ ceph mds rmfailed 0 --yes-i-really-mean-it

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by John Spray almost 8 years ago

Without looking at the code, I would imagine that you're seeing EINVAL for rank 1 because there is no such rank (so it doesn't make sense to try and remove it from the failed set).

You're seeing 0 for rank 0 because Ceph CLI commands are idempotent, so whenever we have a removal -type operation we will return success if it is not present.

This isn't a bug as such but probably could be a bit friendlier by printing a message saying that the rank you're asking to remove from the failed set was already removed.

Actions

Copy link