Project

General

Profile

Bug #16433

Potential crash during journal::Replay shut down

Added by Jason Dillaman almost 8 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jason Dillaman
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
jewel
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Replay<I>::handle_op_complete shouldn't be holding the mutex when invoking the callback:

2016-06-22T16:26:44.685 INFO:tasks.workunit.client.0.target074122.stdout:[ RUN      ] TestJournalReplay.Rename
2016-06-22T16:26:44.901 INFO:tasks.workunit.client.0.target074122.stderr:common/Mutex.cc: In function 'Mutex::~Mutex()' thread 7feb8cff9700 time 2016-06-22 16:26:44.906287
2016-06-22T16:26:44.902 INFO:tasks.workunit.client.0.target074122.stderr:common/Mutex.cc: 77: FAILED assert(nlock == 0)
2016-06-22T16:26:44.902 INFO:tasks.workunit.client.0.target074122.stderr: ceph version 10.2.0-2647-g6c98750 (6c98750f91d0664a5ab3d63a503dab3373a9762a)
2016-06-22T16:26:44.902 INFO:tasks.workunit.client.0.target074122.stderr: 1: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x8b) [0x7febac1939ab]
2016-06-22T16:26:44.902 INFO:tasks.workunit.client.0.target074122.stderr: 2: (Mutex::~Mutex()+0x109) [0x7febac174379]
2016-06-22T16:26:44.903 INFO:tasks.workunit.client.0.target074122.stderr: 3: (librbd::Journal<librbd::ImageCtx>::handle_flushing_replay()+0x9d) [0x7febabfe97cd]
2016-06-22T16:26:44.903 INFO:tasks.workunit.client.0.target074122.stderr: 4: (librbd::Journal<librbd::ImageCtx>::handle_replay_complete(int)::{lambda(int)#1}::operator()(int) const+0x88) [0x7febabfe99f8]
2016-06-22T16:26:44.903 INFO:tasks.workunit.client.0.target074122.stderr: 5: (FunctionContext::finish(int)+0x1a) [0x7febabfad7ba]
2016-06-22T16:26:44.903 INFO:tasks.workunit.client.0.target074122.stderr: 6: (Context::complete(int)+0x9) [0x7febabf0e9f9]
2016-06-22T16:26:44.904 INFO:tasks.workunit.client.0.target074122.stderr: 7: (ContextWQ::process(Context*)+0xe4) [0x7febabfa7bc4]
2016-06-22T16:26:44.904 INFO:tasks.workunit.client.0.target074122.stderr: 8: (ThreadPool::worker(ThreadPool::WorkThread*)+0xb65) [0x7febac19a495]
2016-06-22T16:26:44.904 INFO:tasks.workunit.client.0.target074122.stderr: 9: (ThreadPool::WorkThread::entry()+0x10) [0x7febac19b450]
2016-06-22T16:26:44.905 INFO:tasks.workunit.client.0.target074122.stderr: 10: (()+0x8184) [0x7febab753184]
2016-06-22T16:26:44.905 INFO:tasks.workunit.client.0.target074122.stderr: 11: (clone()+0x6d) [0x7feba988c37d]
2016-06-22T16:26:44.905 INFO:tasks.workunit.client.0.target074122.stderr: NOTE: a copy of the executable, or `objdump -rdS <executable>` is needed to interpret this.
2016-06-22T16:26:45.291 INFO:tasks.workunit.client.0.target074122.stderr:Aborted (core dumped)

Related issues

Copied to rbd - Backport #16458: jewel: Potential crash during journal::Replay shut down Resolved

History

#1 Updated by Jason Dillaman almost 8 years ago

  • Status changed from In Progress to Fix Under Review

#2 Updated by Mykola Golub almost 8 years ago

  • Status changed from Fix Under Review to Pending Backport

#3 Updated by Nathan Cutler almost 8 years ago

  • Copied to Backport #16458: jewel: Potential crash during journal::Replay shut down added

#4 Updated by Loïc Dachary over 7 years ago

  • Status changed from Pending Backport to Resolved

Also available in: Atom PDF