Bug #16327
comparing return code to ERR_NOT_MODIFIED in rgw_rest_s3.cc (needs minus sign)
% Done:
0%
Source:
other
Tags:
Backport:
jewel,hammer
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):
Description
We are returning -ERR_NOT_MODIFIED
but in rgw_rest_s3.cc the conditional omits the minus sign:
$ grep -r ERR_NOT_MODIFIED src/rgw/rgw_common.h:#define ERR_NOT_MODIFIED 2016 src/rgw/rgw_rest_s3.cc: if (op_ret == ERR_NOT_MODIFIED) { src/rgw/rgw_rados.cc: if (copy_if_newer && ret == -ERR_NOT_MODIFIED) { src/rgw/rgw_rados.cc: return -ERR_NOT_MODIFIED; src/rgw/rgw_rados.cc: return -ERR_NOT_MODIFIED; src/rgw/rgw_http_errors.h: { ERR_NOT_MODIFIED, 304, "NotModified" }, src/rgw/rgw_http_errors.h: return -ERR_NOT_MODIFIED;
Related issues
History
#1 Updated by Nathan Cutler almost 8 years ago
- Status changed from New to Fix Under Review
master PR: https://github.com/ceph/ceph/pull/9725
#2 Updated by Nathan Cutler almost 8 years ago
- Related to Backport #15283: hammer: RGW shouldn't send Content-Type nor Content-Length for 304 responses added
#3 Updated by Nathan Cutler almost 8 years ago
- Status changed from Fix Under Review to Resolved
#4 Updated by Nathan Cutler almost 8 years ago
- Status changed from Resolved to Pending Backport
- Backport set to jewel,hammer
#5 Updated by Nathan Cutler almost 8 years ago
- Copied to Backport #16381: jewel: comparing return code to ERR_NOT_MODIFIED in rgw_rest_s3.cc (needs minus sign) added
#6 Updated by Nathan Cutler almost 8 years ago
- Copied to Backport #16382: hammer: comparing return code to ERR_NOT_MODIFIED in rgw_rest_s3.cc (needs minus sign) added
#7 Updated by Nathan Cutler almost 8 years ago
- Related to deleted (Backport #15283: hammer: RGW shouldn't send Content-Type nor Content-Length for 304 responses)
#8 Updated by Loïc Dachary over 7 years ago
- Status changed from Pending Backport to Resolved