https://tracker.ceph.com/https://tracker.ceph.com/favicon.ico2016-06-03T12:00:03ZCeph rbd - Cleanup #16130: Proxied operations shouldn't result in error messages if replayedhttps://tracker.ceph.com/issues/16130?journal_id=719792016-06-03T12:00:03ZVikhyat Umrao
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li><li><strong>Assignee</strong> set to <i>Vikhyat Umrao</i></li></ul> rbd - Cleanup #16130: Proxied operations shouldn't result in error messages if replayedhttps://tracker.ceph.com/issues/16130?journal_id=720292016-06-03T18:47:35ZVikhyat Umrao
<ul></ul><p>@Jason , I hope here you meant we should not return replay errors in Snapshot<Type>Request . For types : snap create, snap rename, snap remove, snap protect, snap unprotect, and rename if replayed.</p> rbd - Cleanup #16130: Proxied operations shouldn't result in error messages if replayedhttps://tracker.ceph.com/issues/16130?journal_id=721542016-06-07T13:26:31ZVikhyat Umrao
<ul></ul><p>- I have tested in latest master and I am not getting these error messages from Snapshot<Type>Request, if replayed :</p>
<pre>
./rbd snap rename rbd/testrbd@snap1 rbd/testrbd@snap1
rbd: renaming snap failed: (17) File exists
./rbd -p rbd ls -l
NAME SIZE PARENT FMT PROT LOCK
testrbd 1024k 2
testrbd@snap1 1024k 2 yes
testrbd@testsnap 1024k 2
./rbd snap protect rbd/testrbd@snap1
rbd: protecting snap failed: (16) Device or resource busy
$ ./rbd snap unprotect rbd/testrbd@snap1
$ ./rbd snap unprotect rbd/testrbd@snap1
rbd: unprotecting snap failed: (22) Invalid argument
</pre>
<p>- This is my current understanding or I am missing something ?</p> rbd - Cleanup #16130: Proxied operations shouldn't result in error messages if replayedhttps://tracker.ceph.com/issues/16130?journal_id=721612016-06-07T13:48:02ZJason Dillamandillaman@redhat.com
<ul></ul><p>@Vikhyat: yes, we should suppress the lderr log messages from the state machines if it's possible to hit the error from a duplicated op (e.g. ldout but don't lderr in SnapshotRemoveRequest if you hit -ENOENT attempting to remove a snapshot).</p> rbd - Cleanup #16130: Proxied operations shouldn't result in error messages if replayedhttps://tracker.ceph.com/issues/16130?journal_id=727582016-06-15T14:17:03ZVikhyat Umrao
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Fix Under Review</i></li></ul><p><a class="external" href="https://github.com/ceph/ceph/pull/9724">https://github.com/ceph/ceph/pull/9724</a></p> rbd - Cleanup #16130: Proxied operations shouldn't result in error messages if replayedhttps://tracker.ceph.com/issues/16130?journal_id=752552016-07-24T15:13:56ZJason Dillamandillaman@redhat.com
<ul><li><strong>Status</strong> changed from <i>Fix Under Review</i> to <i>Resolved</i></li></ul> rbd - Cleanup #16130: Proxied operations shouldn't result in error messages if replayedhttps://tracker.ceph.com/issues/16130?journal_id=789832016-09-26T23:03:19ZKen Dreyerkdreyer@redhat.com
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Pending Backport</i></li><li><strong>Backport</strong> set to <i>jewel</i></li></ul> rbd - Cleanup #16130: Proxied operations shouldn't result in error messages if replayedhttps://tracker.ceph.com/issues/16130?journal_id=791682016-10-03T13:29:27ZLoïc Dacharyloic@dachary.org
<ul><li><strong>Copied to</strong> <i><a class="issue tracker-9 status-3 priority-4 priority-default closed" href="/issues/17481">Backport #17481</a>: jewel: Proxied operations shouldn't result in error messages if replayed</i> added</li></ul> rbd - Cleanup #16130: Proxied operations shouldn't result in error messages if replayedhttps://tracker.ceph.com/issues/16130?journal_id=801402016-10-20T14:40:12ZLoïc Dacharyloic@dachary.org
<ul><li><strong>Status</strong> changed from <i>Pending Backport</i> to <i>Resolved</i></li></ul>