Project

General

Profile

Actions

Bug #16096

closed

librbd: feature updates are not seen by mirror_image_enable()

Added by Jon Bernard almost 8 years ago. Updated almost 8 years ago.

Status:
Resolved
Priority:
High
Assignee:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
jewel
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

I'm making two calls to librbd:

1. feature_update(JOURNALING)
2. mirror_image_enable()

The mirror call [2] fails, reporting that journaling is not enabled. But the rbd client confirms that the feature_update() call did succeed in setting the journaling flag. If before line [2], I add a call to fetch the existing image features, then the mirror_image_enable call succeeds.

It sounds like mirror_image_enable is getting the update but not re-reading the header, while features() does the usual check if there are pending notifications to process before fetching the features.

If this isn't a high-priority issue, would you mind if I work on this?


Related issues 1 (0 open1 closed)

Copied to rbd - Backport #16216: jewel: librbd: feature updates are not seen by mirror_image_enable()ResolvedJason DillamanActions
Actions #1

Updated by Josh Durgin almost 8 years ago

  • Project changed from Ceph to rbd
  • Subject changed from RBD,MIRROR: feature updates are not seen by mirror_image_enable() to librbd: feature updates are not seen by mirror_image_enable()
  • Priority changed from Normal to High
Actions #2

Updated by Jason Dillaman almost 8 years ago

  • Backport set to jewel

@Jon: feel free to work on it. All the API external "mirror_image_XYZ" methods within internal.cc should refresh the image if needed.

Actions #4

Updated by Jason Dillaman almost 8 years ago

  • Status changed from New to Fix Under Review
Actions #5

Updated by Jason Dillaman almost 8 years ago

  • Status changed from Fix Under Review to Pending Backport
Actions #6

Updated by Jason Dillaman almost 8 years ago

  • Copied to Backport #16216: jewel: librbd: feature updates are not seen by mirror_image_enable() added
Actions #7

Updated by Jason Dillaman almost 8 years ago

  • Status changed from Pending Backport to Resolved
Actions

Also available in: Atom PDF