Project

General

Profile

Feature #15983

mon : add osdmap flags set and unset message when osdmap flags are already set and unset

Added by Vikhyat Umrao about 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
% Done:

0%

Source:
other
Tags:
Backport:
Reviewed:
Affected Versions:
Pull request ID:

Description

mon : add osdmap flags set and unset message when osdmap flags are already set and unset


$./ceph osd set noout
set noout 

$./ceph -s
    cluster 6f353b36-cb94-4a34-982d-81158f6d9641
     health HEALTH_WARN
            noout,sortbitwise flag(s) set
     monmap e1: 3 mons at {a=192.168.200.47:6789/0,b=192.168.200.47:6790/0,c=192.168.200.47:6791/0}
            election epoch 4, quorum 0,1,2 a,b,c
      fsmap e5: 1/1/1 up {0=b=up:active}, 2 up:standby
     osdmap e18: 3 osds: 3 up, 3 in
            flags noout,sortbitwise
      pgmap v91: 24 pgs, 3 pools, 2068 bytes data, 20 objects
            143 GB used, 156 GB / 299 GB avail
                  24 active+clean

$./ceph osd set noout
set noout <---------------------- no message if flag is already set it gives same message "set flag-name" 

$./ceph osd unset noout
unset noout

 $ ./ceph -s
    cluster 6f353b36-cb94-4a34-982d-81158f6d9641
     health HEALTH_OK
     monmap e1: 3 mons at {a=192.168.200.47:6789/0,b=192.168.200.47:6790/0,c=192.168.200.47:6791/0}
            election epoch 4, quorum 0,1,2 a,b,c
      fsmap e5: 1/1/1 up {0=b=up:active}, 2 up:standby
     osdmap e21: 3 osds: 3 up, 3 in
            flags sortbitwise
      pgmap v114: 24 pgs, 3 pools, 2068 bytes data, 20 objects
            143 GB used, 156 GB / 299 GB avail
                  24 active+clean

$./ceph osd unset noout
unset noout <---------------------- no message if flag is not set it gives same message "unset flag-name" 

- Currently if we set or unset already set and unset osdmap flags we do not get any message like

- <flag_name> flag is already set - if flag is already set and we are setting it
- <flag_name> flag is not set - if flag is not set and we are unsetting it

History

#1 Updated by Vikhyat Umrao about 4 years ago

  • Description updated (diff)

#2 Updated by Vikhyat Umrao about 4 years ago

  • Status changed from In Progress to Fix Under Review

#3 Updated by Kefu Chai about 4 years ago

  • Status changed from Fix Under Review to Resolved

Also available in: Atom PDF