Project

General

Profile

Backport #15867

hammer: ceph-disk s/by-parttype-uuid/by-parttypeuuid/

Added by Loïc Dachary over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
Release:
hammer
Crash signature (v1):
Crash signature (v2):

History

#1 Updated by Loïc Dachary over 6 years ago

inconsistencies in by-parttypeuuid in man ceph-disk and also the python script for ceph-disk. Customer believes this should always use correct name to avoid confusion.

e.g. “man ceph-disk” says:
“ activate-all
Activate all tagged OSD partitions. activate-all relies on /dev/disk/by-parttype-uuid/$typeuuid.$uuid to find all partitions. Special udev rules are installed to create these
links. It is triggered on ceph service start or run directly.

And the python script also has the incorrect name:

  1. grep by-parttype /usr/sbin/*
    /usr/sbin/ceph-disk:activate-all relies on /dev/disk/by-parttype-uuid/$typeuuid.$uuid to --> Incorrect
    /usr/sbin/ceph-disk: dir = '/dev/disk/by-parttypeuuid' ---> Correct
    /usr/sbin/ceph-disk-udev:mkdir -p /dev/disk/by-parttypeuuid --> Correct
    /usr/sbin/ceph-disk-udev:ln -sf ../../${NAME} /dev/disk/by-parttypeuuid/${ID_PART_ENTRY_TYPE}.${ID_PART_ENTRY_UUID}

The correct name is “by-parttypeuuid”, as seen here:

  1. ll
    total 0
    drwxr-xr-x 2 root root 840 Apr 25 16:14 by-id
    drwxr-xr-x 2 root root 60 Apr 25 17:09 by-partlabel
    drwxr-xr-x 2 root root 120 Apr 25 17:09 by-parttypeuuid
    drwxr-xr-x 2 root root 120 Apr 25 17:09 by-partuuid
    drwxr-xr-x 2 root root 700 Apr 25 16:14 by-path

#2 Updated by Loïc Dachary over 6 years ago

this issue has been fixed in jewel

#3 Updated by Nathan Cutler over 6 years ago

  • Assignee set to Nathan Cutler

#4 Updated by Nathan Cutler over 6 years ago

  • Description updated (diff)
  • Status changed from New to In Progress

#5 Updated by Nathan Cutler over 6 years ago

  • Status changed from In Progress to Resolved

#6 Updated by Ken Dreyer over 6 years ago

will be in v0.94.8

#7 Updated by Loïc Dachary over 6 years ago

  • Target version set to v0.94.8

#8 Updated by Ken Dreyer over 6 years ago

  • Status changed from Resolved to In Progress

On Hammer, the nroff source needs to be regenerated.

#9 Updated by Ken Dreyer over 6 years ago

  • Status changed from In Progress to Fix Under Review
  • Target version deleted (v0.94.8)

#10 Updated by Loïc Dachary over 6 years ago

  • Status changed from Fix Under Review to Resolved

#11 Updated by Ken Dreyer over 6 years ago

  • Target version set to v0.94.8

Also available in: Atom PDF